-
-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish Webhooks, and add config endpoint for client #1265
Open
thedudedies21
wants to merge
14
commits into
spacebarchat:master
Choose a base branch
from
thedudedies21:Update_Base_Webhooks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Finish Webhooks, and add config endpoint for client #1265
thedudedies21
wants to merge
14
commits into
spacebarchat:master
from
thedudedies21:Update_Base_Webhooks
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update_webhooks
Finish base webhooks
Update base webhooks
ran prettier locally with write to fix flake.lock |
MathMan05
reviewed
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, forgot to finish this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this update, I have taken some time to add in a customizable naming system for webhooks that allows instance owner more control over the naming of their webhooks, as well as added in an endpoint at
/api/policies/instance/config
that will allow the client to get data that it may need to function and behave as expected. This lays the groundwork for other webhook updates potentially in the future to allow for more growth.The config endpoint currently provides data that Jank Client and other clients may need to impose per instance limitations, including message length, public correspondence information, and registration information