Compatibility changes for Discord.py by whinis · Pull Request #1572 · spacebarchat/server

whinis · 2026-03-05T23:57:27Z

Added the JsonRemoteEmpty to more fields in the message class

MathMan05 · 2026-03-06T00:06:55Z

When I get a chance I'll review this change

whinis · 2026-03-06T00:56:31Z

Thats ok, I am using this as a draft to fix multiple issues with discord.py so going to try a few things first.

e-lisa · 2026-03-06T01:41:46Z

Still breaking on member.flags

https://github.com/Rapptz/discord.py/blob/master/discord/member.py#L331

(sorry, i was running a patched version of discord.py to bypass this, but this will break for others)

Exception in thread Thread-1 (run_discord):
Traceback (most recent call last):
File "/usr/lib/python3.13/threading.py", line 1043, in _bootstrap_inner
self.run()
~~~~~~~~^^
File "/usr/lib/python3.13/threading.py", line 994, in run
self._target(*self._args, **self._kwargs)
~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/bin/catpuppetbridge", line 40, in run_discord
discordbot.run(discord_token)
~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/client.py", line 929, in run
asyncio.run(runner())
~~~~~~~~~~~^^^^^^^^^^
File "/usr/lib/python3.13/asyncio/runners.py", line 195, in run
return runner.run(main)
~~~~~~~~~~^^^^^^
File "/usr/lib/python3.13/asyncio/runners.py", line 118, in run
return self._loop.run_until_complete(task)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
File "/usr/lib/python3.13/asyncio/base_events.py", line 725, in run_until_complete
return future.result()
~~~~~~~~~~~~~^^
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/client.py", line 918, in runner
await self.start(token, reconnect=reconnect)
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/client.py", line 847, in start
await self.connect(reconnect=reconnect)
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/client.py", line 727, in connect
await self.ws.poll_event()
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/gateway.py", line 635, in poll_event
await self.received_message(msg.data)
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/gateway.py", line 582, in received_message
func(data)
~~~~^^^^^^
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/state.py", line 1322, in parse_guild_create
guild = self._get_create_guild(data)
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/state.py", line 1263, in _get_create_guild
return self._add_guild_from_data(data)
~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/state.py", line 530, in _add_guild_from_data
guild = Guild(data=data, state=self)
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/guild.py", line 473, in __init__
self._from_data(data)
~~~~~~~~~~~~~~~^^^^^^
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/guild.py", line 654, in _from_data
member = Member(data=mdata, guild=self, state=self._state)  # type: ignore # Members will have the 'user' key in this scenario
File "/usr/local/lib/catpuppetbridge/venv/lib/python3.13/site-packages/discord/member.py", line 329, in __init__
self._flags: int = data['flags']
~~~~^^^^^^^^^
KeyError: 'flags'

MathMan05

https://docs.discord.food/resources/message#message-object
Please use the documentation to replicate the structure of the message object. I could be wrong in some of these spots.

MathMan05 · 2026-03-06T02:41:56Z

src/util/entities/Channel.ts

+        // the position field. Needs to be looked into more
+        // TODO: Look into when this can be undefined during CHANNEL_UPDATE
+        if (this.position === undefined) {
+            this.position = 0;


please do this in the object instead

MathMan05 · 2026-03-06T02:42:10Z

src/util/entities/Message.ts

    @Column({ nullable: true })
    @RelationId((message: Message) => message.channel)
    @Index()
+    @JsonRemoveEmpty


This is not optional

MathMan05 · 2026-03-06T02:42:56Z

src/util/entities/Message.ts


    @Column({ nullable: true })
    @RelationId((message: Message) => message.thread)
+    @JsonRemoveEmpty


This is not a property that should end up in the result

MathMan05 · 2026-03-06T02:43:39Z

src/util/entities/Message.ts


    @Column({ nullable: true })
    @RelationId((message: Message) => message.guild)
+    @JsonRemoveEmpty


This is not a property of the message object

MathMan05 · 2026-03-06T02:43:53Z

src/util/entities/Message.ts

    @ManyToOne(() => Guild, {
        onDelete: "CASCADE",
    })
+    @JsonRemoveEmpty


This is not a property of the message object

MathMan05 · 2026-03-06T02:47:33Z

src/util/entities/Message.ts

    edited_timestamp?: Date;

    @Column({ nullable: true })
+    @JsonRemoveEmpty


Not sure why it's marked as such, but it's not optional

MathMan05 · 2026-03-06T02:47:54Z

src/util/entities/Message.ts


    @Column({ nullable: true })
+    @JsonRemoveEmpty
    mention_everyone?: boolean;


Not sure why it's marked as such, but it's not optional

MathMan05 · 2026-03-06T02:49:00Z

src/util/entities/Message.ts

    nonce?: string;

    @Column({ nullable: true, type: Date })
+    @JsonRemoveEmpty


this is not a part of the message, and you can see the type includes null

MathMan05 · 2026-03-06T02:53:29Z

src/util/entities/Message.ts


    @Column({ nullable: true })
+    @JsonRemoveEmpty
    username?: string;


This does not matter as it's just being used then defaulted if nullish

MathMan05 · 2026-03-06T02:53:45Z

src/util/entities/Message.ts

    username?: string;

    @Column({ nullable: true })
+    @JsonRemoveEmpty


This does not matter as it's just being used then defaulted if nullish

e-lisa · 2026-03-07T15:53:12Z

~~replied_to = await message.channel.fetch_message(message.reference.message_id)~~

EXPECTED BEHAVIOR:
When getting the author of replied to messages, there should be a message.author (in the example above, replied_to.author on fetched messages from the channel.

CURRENT BEHAVIOR:
message.author is missing when fetched from await message.channel.fetch_message

Fixed in: #1594

e-lisa · 2026-03-15T15:17:02Z

Currently running this on our production instance with out any issues am curious what @s074, @CyberL1 or @TheArcaneBrony think of these changes?

Can confirm, it does fix the issues with discord.py, and doesn't appear to break anything as far as i can tell

s074 · 2026-03-15T16:42:26Z

Glad this solved the issue with Discord.py

I think we should just create a separate DTO for message. Using our Message entity class as dto is both, polluting the entity class with serialization code, and possibly causing type problems since our message dto will have to include additional properties that need to be computed at send time. We are already encountering the second problem with MessageUpdateEvent which uses Message entity class as its type for data, and we had a discussion about it yesterday

We can create a separate type for a Message DTO, and also include a helper function for mapping a message entity object to dto toMessageDto(message: Message)

e-lisa · 2026-03-15T17:38:53Z

I think we should just create a separate DTO for message. Using our Message entity class as dto is both, polluting the entity class with serialization code, and possibly causing type problems since our message dto will have to include
We can create a separate type for a Message DTO, and also include a helper function for mapping a message entity object to dto toMessageDto(message: Message)

I think this is the way to go. It feels like we've out grown it living in the Entity and its being pulled in too many different directions.

TheArcaneBrony · 2026-03-15T17:50:55Z

if you look my recent changes, you mightve seen me trying to get rid of entities being used as DTOs as a whole

whinis · 2026-03-15T19:48:56Z

Its also why this is still a draft, some changes have been imported into other PRs but there are lots of changes right now

…ssage class. Hopefully shouldn't break anything.

whinis marked this pull request as draft March 5, 2026 23:57

whinis force-pushed the AddEmptyDecoratorToMostMessageFields branch from 621c153 to d452006 Compare March 6, 2026 01:03

MathMan05 reviewed Mar 6, 2026

View reviewed changes

whinis changed the title ~~Add Decorators to More Fields~~ Compatibility changes for Discord.py Mar 6, 2026

whinis added 2 commits March 21, 2026 16:29

Added the @JsonRemoveEmpty decrorator to most of the fields in the me…

d4cc9a5

…ssage class. Hopefully shouldn't break anything.

Maybe fix an issue elisa had with discord.py

f5c60a3

whinis force-pushed the AddEmptyDecoratorToMostMessageFields branch from d452006 to f5c60a3 Compare March 21, 2026 20:32

Uh oh!

Conversation

whinis commented Mar 5, 2026

Uh oh!

MathMan05 commented Mar 6, 2026

Uh oh!

whinis commented Mar 6, 2026

Uh oh!

e-lisa commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MathMan05 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

e-lisa commented Mar 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

e-lisa commented Mar 15, 2026

Uh oh!

s074 commented Mar 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

e-lisa commented Mar 15, 2026

Uh oh!

TheArcaneBrony commented Mar 15, 2026

Uh oh!

whinis commented Mar 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

e-lisa commented Mar 6, 2026 •

edited

Loading

e-lisa commented Mar 7, 2026 •

edited

Loading

s074 commented Mar 15, 2026 •

edited

Loading