Add joined private archived thread listing#1647
Closed
samuelscheit wants to merge 1 commit into
Closed
Conversation
b8a54d9 to
772786f
Compare
Member
Author
|
Code review completed after the latest update. I found no blocking issues; the PR is approved from my review. |
772786f to
583b9bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /channels/:channel_id/users/@me/threads/archived/privatehas_morepaginationRoot cause
The server had thread creation/member APIs but no route for listing archived private threads joined by the current user, so clients could not page through their joined private archived threads for a parent channel.
Closes #125
Validation
npm run node:testsnpm run build:src -- --pretty falsenode -r dotenv/config -r module-alias/register --enable-source-maps --test dist/api/util/utility/JoinedPrivateArchivedThreads.test.jsnpx eslint src/api/routes/channels/#channel_id/users/@me/threads/archived/private.ts src/api/util/utility/JoinedPrivateArchivedThreads.ts src/api/util/utility/JoinedPrivateArchivedThreads.test.tsnpx prettier --check src/api/routes/channels/#channel_id/users/@me/threads/archived/private.ts src/api/util/utility/JoinedPrivateArchivedThreads.ts src/api/util/utility/JoinedPrivateArchivedThreads.test.tsgit diff --check