Skip to content

Add joined private archived thread listing#1647

Closed
samuelscheit wants to merge 1 commit into
spacebarchat:masterfrom
samuelscheit2:fix/125-joined-private-archived-threads
Closed

Add joined private archived thread listing#1647
samuelscheit wants to merge 1 commit into
spacebarchat:masterfrom
samuelscheit2:fix/125-joined-private-archived-threads

Conversation

@samuelscheit
Copy link
Copy Markdown
Member

Summary

  • add GET /channels/:channel_id/users/@me/threads/archived/private
  • filter archived private child threads to only those joined by the requesting guild member
  • return Discord-compatible thread member objects for the current user and has_more pagination
  • cover query construction, limit/before parsing, pagination, permissions, and member serialization with node:test

Root cause

The server had thread creation/member APIs but no route for listing archived private threads joined by the current user, so clients could not page through their joined private archived threads for a parent channel.

Closes #125

Validation

  • npm run node:tests
  • npm run build:src -- --pretty false
  • node -r dotenv/config -r module-alias/register --enable-source-maps --test dist/api/util/utility/JoinedPrivateArchivedThreads.test.js
  • npx eslint src/api/routes/channels/#channel_id/users/@me/threads/archived/private.ts src/api/util/utility/JoinedPrivateArchivedThreads.ts src/api/util/utility/JoinedPrivateArchivedThreads.test.ts
  • npx prettier --check src/api/routes/channels/#channel_id/users/@me/threads/archived/private.ts src/api/util/utility/JoinedPrivateArchivedThreads.ts src/api/util/utility/JoinedPrivateArchivedThreads.test.ts
  • git diff --check

@samuelscheit samuelscheit force-pushed the fix/125-joined-private-archived-threads branch from b8a54d9 to 772786f Compare May 6, 2026 09:49
@samuelscheit samuelscheit marked this pull request as ready for review May 6, 2026 09:51
Copilot AI review requested due to automatic review settings May 6, 2026 09:51
@samuelscheit
Copy link
Copy Markdown
Member Author

Code review completed after the latest update. I found no blocking issues; the PR is approved from my review.

@samuelscheit samuelscheit force-pushed the fix/125-joined-private-archived-threads branch from 772786f to 583b9bd Compare May 6, 2026 09:56
@samuelscheit samuelscheit review requested due to automatic review settings May 6, 2026 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route: /channels/:id/users/@me/threads/archived/private

1 participant