Support install prefixes with spaces#41
Open
johnwparent wants to merge 4 commits into
Open
Conversation
johnwparent
force-pushed
the
make-install-work-with-path-spaces
branch
from
2c61854 to
37b799f
Compare
Allows installation into paths with spaces Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
force-pushed
the
make-install-work-with-path-spaces
branch
from
37b799f to
f5a25f8
Compare
Signed-off-by: John Parent <john.parent@kitware.com>
Signed-off-by: John Parent <john.parent@kitware.com>
Signed-off-by: John Parent <john.parent@kitware.com>
johnwparent
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evidently we missed a few places that choke if there's a space in the install prefix
Note: MAKEDIR usage in the makefile is not quoted like PREFIX is as it is only used with
SETthus far andSETdoes not care about whitespace (in that it allows it and does not break on whitespace), if MAKEDIR is needed with a nonSETcommand later, it should be quoted at that time