Configure flux pre-deployment for webhook-handler #894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjnesbitt
force-pushed
the
flux-django-pre-deploy
branch
from
b43cc64 to
7c002d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue we have with our current deployment for the webhook handler. Currently, we simply run
migrateas an entrypoint on the webhook deployment container, which means that when the deployment is updated, all pods run this essentially simultaneously. Instead, what we'd like to do is runmigrateonce before the entire deployment is rolled out.This implementation is based on these flux docs. Opening this as a draft PR to start as I'm not sure how to reconcile (heh) the kustomizations defined here vs our main kustomization. @mvandenburgh when you have a chance please take a look and lmk what you think.