Nat/enhance gpu support

[natshineman]

Removes some outdated options from the package and provides some more options and dependencies for GPU enabled builds.

Also adds the "cray" PM for builds on Cray systems with slurm as the launcher. These builds require different PMI libraries from standard slurm builds.

[tldahlgren]

Added missing maintainers to Reviewer list.

[tldahlgren]

@spackbot fix style

[spackbot-app]

Let me see if I can fix that for you!

[spackbot-app]

I was able to run spack style --fix for you!

spack style --fix

repos/spack_repo/builtin/build_systems/cmake.py
repos/spack_repo/builtin/build_systems/oneapi.py
repos/spack_repo/builtin/packages/amdsmi/package.py
repos/spack_repo/builtin/packages/arkouda/package.py
repos/spack_repo/builtin/packages/ascent/package.py
repos/spack_repo/builtin/packages/cabana/package.py
repos/spack_repo/builtin/packages/cbindgen/package.py
repos/spack_repo/builtin/packages/codipack/package.py
repos/spack_repo/builtin/packages/comgr/package.py
repos/spack_repo/builtin/packages/composable_kernel/package.py
repos/spack_repo/builtin/packages/cprnc/package.py
repos/spack_repo/builtin/packages/dd4hep/package.py
repos/spack_repo/builtin/packages/dotnet_core_sdk/package.py
repos/spack_repo/builtin/packages/fargparse/package.py
repos/spack_repo/builtin/packages/gftl/package.py
repos/spack_repo/builtin/packages/gftl_shared/package.py
repos/spack_repo/builtin/packages/ginkgo/package.py
repos/spack_repo/builtin/packages/gnutls/package.py
repos/spack_repo/builtin/packages/go/package.py
repos/spack_repo/builtin/packages/graphviz/package.py
repos/spack_repo/builtin/packages/grpc/package.py
repos/spack_repo/builtin/packages/harfbuzz/package.py
repos/spack_repo/builtin/packages/hip/package.py
repos/spack_repo/builtin/packages/hip_tensor/package.py
repos/spack_repo/builtin/packages/hip_tests/package.py
repos/spack_repo/builtin/packages/hipblas/package.py
repos/spack_repo/builtin/packages/hipblas_common/package.py
repos/spack_repo/builtin/packages/hipblaslt/package.py
repos/spack_repo/builtin/packages/hipcc/package.py
repos/spack_repo/builtin/packages/hipcub/package.py
repos/spack_repo/builtin/packages/hipfft/package.py
repos/spack_repo/builtin/packages/hipfort/package.py
repos/spack_repo/builtin/packages/hipify_clang/package.py
repos/spack_repo/builtin/packages/hiprand/package.py
repos/spack_repo/builtin/packages/hipsolver/package.py
repos/spack_repo/builtin/packages/hipsparse/package.py
repos/spack_repo/builtin/packages/hipsparselt/package.py
repos/spack_repo/builtin/packages/hsa_rocr_dev/package.py
repos/spack_repo/builtin/packages/ioapi/package.py
repos/spack_repo/builtin/packages/kokkos_tools/package.py
repos/spack_repo/builtin/packages/lammps/package.py
repos/spack_repo/builtin/packages/lcio/package.py
repos/spack_repo/builtin/packages/libmetatensor_torch/package.py
repos/spack_repo/builtin/packages/libmetatomic_torch/package.py
repos/spack_repo/builtin/packages/libunwind/package.py
repos/spack_repo/builtin/packages/llvm/package.py
repos/spack_repo/builtin/packages/llvm_amdgpu/package.py
repos/spack_repo/builtin/packages/mapl/package.py
repos/spack_repo/builtin/packages/med/package.py
repos/spack_repo/builtin/packages/melissa/package.py
repos/spack_repo/builtin/packages/migraphx/package.py
repos/spack_repo/builtin/packages/miopen_hip/package.py
repos/spack_repo/builtin/packages/mivisionx/package.py
repos/spack_repo/builtin/packages/mpich/package.py
repos/spack_repo/builtin/packages/mvapich/package.py
repos/spack_repo/builtin/packages/mvapich_plus/package.py
repos/spack_repo/builtin/packages/netcdf_c/package.py
repos/spack_repo/builtin/packages/netlib_xblas/package.py
repos/spack_repo/builtin/packages/parallelio/package.py
repos/spack_repo/builtin/packages/petaca/package.py
repos/spack_repo/builtin/packages/petsc/package.py
repos/spack_repo/builtin/packages/pflogger/package.py
repos/spack_repo/builtin/packages/pfunit/package.py
repos/spack_repo/builtin/packages/pika/package.py
repos/spack_repo/builtin/packages/podio/package.py
repos/spack_repo/builtin/packages/precice/package.py
repos/spack_repo/builtin/packages/prmon/package.py
repos/spack_repo/builtin/packages/proj/package.py
repos/spack_repo/builtin/packages/py_arkouda/package.py
repos/spack_repo/builtin/packages/py_cartopy/package.py
repos/spack_repo/builtin/packages/py_charset_normalizer/package.py
repos/spack_repo/builtin/packages/py_equinox/package.py
repos/spack_repo/builtin/packages/py_fenics_dolfinx/package.py
repos/spack_repo/builtin/packages/py_gpaw/package.py
repos/spack_repo/builtin/packages/py_jaxlib/package.py
repos/spack_repo/builtin/packages/py_kiwisolver/package.py
repos/spack_repo/builtin/packages/py_melissa_core/package.py
repos/spack_repo/builtin/packages/py_metatensor_core/package.py
repos/spack_repo/builtin/packages/py_metatensor_torch/package.py
repos/spack_repo/builtin/packages/py_metatomic_torch/package.py
repos/spack_repo/builtin/packages/py_petsc4py/package.py
repos/spack_repo/builtin/packages/py_psyclone/package.py
repos/spack_repo/builtin/packages/py_pyamg/package.py
repos/spack_repo/builtin/packages/py_pygobject/package.py
repos/spack_repo/builtin/packages/py_pyyaml/package.py
repos/spack_repo/builtin/packages/py_rdflib/package.py
repos/spack_repo/builtin/packages/py_reportlab/package.py
repos/spack_repo/builtin/packages/py_requests/package.py
repos/spack_repo/builtin/packages/py_rich/package.py
repos/spack_repo/builtin/packages/py_ruamel_yaml/package.py
repos/spack_repo/builtin/packages/py_ruamel_yaml_clib/package.py
repos/spack_repo/builtin/packages/py_setuptools_scm/package.py
repos/spack_repo/builtin/packages/py_slepc4py/package.py
repos/spack_repo/builtin/packages/py_smartypants/package.py
repos/spack_repo/builtin/packages/py_sniffio/package.py
repos/spack_repo/builtin/packages/py_snowballstemmer/package.py
repos/spack_repo/builtin/packages/py_sphinx/package.py
repos/spack_repo/builtin/packages/py_sphinxcontrib_serializinghtml/package.py
repos/spack_repo/builtin/packages/py_sqlalchemy/package.py
repos/spack_repo/builtin/packages/py_stack_data/package.py
repos/spack_repo/builtin/packages/py_statsmodels/package.py
repos/spack_repo/builtin/packages/py_terminado/package.py
repos/spack_repo/builtin/packages/py_threadpoolctl/package.py
repos/spack_repo/builtin/packages/py_tifffile/package.py
repos/spack_repo/builtin/packages/py_tokenizers/package.py
repos/spack_repo/builtin/packages/python/package.py
repos/spack_repo/builtin/packages/quantum_espresso/package.py
repos/spack_repo/builtin/packages/raja/package.py
repos/spack_repo/builtin/packages/rccl/package.py
repos/spack_repo/builtin/packages/rdc/package.py
repos/spack_repo/builtin/packages/rdma_core/package.py
repos/spack_repo/builtin/packages/repeatmodeler/package.py
repos/spack_repo/builtin/packages/rmgdft/package.py
repos/spack_repo/builtin/packages/rocal/package.py
repos/spack_repo/builtin/packages/rocalution/package.py
repos/spack_repo/builtin/packages/rocblas/package.py
repos/spack_repo/builtin/packages/rocdecode/package.py
repos/spack_repo/builtin/packages/rocfft/package.py
repos/spack_repo/builtin/packages/rocjpeg/package.py
repos/spack_repo/builtin/packages/rocm_bandwidth_test/package.py
repos/spack_repo/builtin/packages/rocm_cmake/package.py
repos/spack_repo/builtin/packages/rocm_core/package.py
repos/spack_repo/builtin/packages/rocm_dbgapi/package.py
repos/spack_repo/builtin/packages/rocm_debug_agent/package.py
repos/spack_repo/builtin/packages/rocm_device_libs/package.py
repos/spack_repo/builtin/packages/rocm_examples/package.py
repos/spack_repo/builtin/packages/rocm_gdb/package.py
repos/spack_repo/builtin/packages/rocm_opencl/package.py
repos/spack_repo/builtin/packages/rocm_openmp_extras/package.py
repos/spack_repo/builtin/packages/rocm_smi_lib/package.py
repos/spack_repo/builtin/packages/rocm_tensile/package.py
repos/spack_repo/builtin/packages/rocm_validation_suite/package.py
repos/spack_repo/builtin/packages/rocminfo/package.py
repos/spack_repo/builtin/packages/rocmlir/package.py
repos/spack_repo/builtin/packages/rocprim/package.py
repos/spack_repo/builtin/packages/rocprofiler_compute/package.py
repos/spack_repo/builtin/packages/rocprofiler_dev/package.py
repos/spack_repo/builtin/packages/rocprofiler_register/package.py
repos/spack_repo/builtin/packages/rocprofiler_sdk/package.py
repos/spack_repo/builtin/packages/rocprofiler_systems/package.py
repos/spack_repo/builtin/packages/rocpydecode/package.py
repos/spack_repo/builtin/packages/rocrand/package.py
repos/spack_repo/builtin/packages/rocshmem/package.py
repos/spack_repo/builtin/packages/rocsolver/package.py
repos/spack_repo/builtin/packages/rocsparse/package.py
repos/spack_repo/builtin/packages/rocthrust/package.py
repos/spack_repo/builtin/packages/roctracer_dev/package.py
repos/spack_repo/builtin/packages/roctracer_dev_api/package.py
repos/spack_repo/builtin/packages/rocwmma/package.py
repos/spack_repo/builtin/packages/rpp/package.py
repos/spack_repo/builtin/packages/scorep/package.py
repos/spack_repo/builtin/packages/scotch/package.py
repos/spack_repo/builtin/packages/seacas/package.py
repos/spack_repo/builtin/packages/singularity_eos/package.py
repos/spack_repo/builtin/packages/slepc/package.py
repos/spack_repo/builtin/packages/stdexec/package.py
repos/spack_repo/builtin/packages/superlu_dist/package.py
repos/spack_repo/builtin/packages/transferbench/package.py
repos/spack_repo/builtin/packages/truchas/package.py
repos/spack_repo/builtin/packages/unuran/package.py
repos/spack_repo/builtin/packages/vecmem/package.py
repos/spack_repo/builtin/packages/vtk/package.py
repos/spack_repo/builtin/packages/yafyaml/package.py
repos/spack_repo/builtin/packages/yasm/package.py
�[1;34m==> �[0mrunning flake8
repos/spack_repo/builtin/packages/mvapich/package.py:34: [E111] indentation is not a multiple of 4
repos/spack_repo/builtin/packages/mvapich/package.py:34: [E117] over-indented
repos/spack_repo/builtin/packages/mvapich/package.py:140: [F541] f-string is missing placeholders
repos/spack_repo/builtin/packages/mvapich/package.py:142: [F541] f-string is missing placeholders
repos/spack_repo/builtin/packages/mvapich/package.py:142: [F541] f-string is missing placeholders
repos/spack_repo/builtin/packages/mvapich_plus/package.py:5: [F401] 'itertools' imported but unused
repos/spack_repo/builtin/packages/mvapich_plus/package.py:62: [E501] line too long (103 > 99 characters)
repos/spack_repo/builtin/packages/mvapich_plus/package.py:154: [F541] f-string is missing placeholders
repos/spack_repo/builtin/packages/mvapich_plus/package.py:156: [F541] f-string is missing placeholders
repos/spack_repo/builtin/packages/mvapich_plus/package.py:156: [F541] f-string is missing placeholders
�[1;34m==> �[0mrunning isort
�[1;34m==> �[0mrunning black

Keep in mind that I cannot fix your flake8 or mypy errors, so if you have any you'll need to fix them and update the pull request. If I was able to push to your branch, if you make further changes you will need to pull from your updated branch before pushing again.

I've updated the branch with style fixes.

But it looks like I'm not able to push to your branch. 😭️ Did you check Allow edits from maintainers when you opened the PR?

[tldahlgren]

Can't confirm mvapich-plus sha256 (since manual download).

Assuming spackbot fixes the style, is there any reason to delay merging this PR (e.g., feedback from other maintainers wanted)?