Remove check for AngleEn register set to 0
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed check for `AngleEn` register set to 0 (sparkfun#6)
|
I just submitted another pull request for this change. Disheartening that you already fixed this 2 years ago and I lost an afternoon debugging to it. |
Member
|
I removed this check in an update I'm working on - I need to verify everything, but will have this incorporated and published within a week. |
Member
|
The issue/fix noted in this PR was included in version 2.0 of this library. Closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed check for
AngleEnregister set to 0 (#6).This is done to prevent failed initialization checks for applications that use the TMAG5273 for angle measurement applications (as in FOC boards). The check seems arbitrary.