You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@disintegrator probably relying on you to tell me whether this change violates some intention somewhere. But also opening to see if we fail the build. Unclear to me if there's an implementation (or principle reason) to include this entry in the workspace root, but it seems like since these are theoretically just templates rather than true packages, it seems like we probably only want to pick up the parent package.
Should prevent local errors running the workspace lint task (pnpm -r lint) and I assume some other undesirable pnpm behaviors.
Given they're explicitly added, I'm guessing there's a good reason I'm not seeing for why they're here.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "gram-template-*" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.
I definitely want them to be part of the workspace because I eventually want them to be targeted by dependabot PRs and separately have their packages as part of the PNPM package cache during CI/CD without any further steps to take.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@disintegrator probably relying on you to tell me whether this change violates some intention somewhere. But also opening to see if we fail the build. Unclear to me if there's an implementation (or principle reason) to include this entry in the workspace root, but it seems like since these are theoretically just templates rather than true packages, it seems like we probably only want to pick up the parent package.
Should prevent local errors running the workspace lint task (
pnpm -r lint) and I assume some other undesirable pnpm behaviors.Given they're explicitly added, I'm guessing there's a good reason I'm not seeing for why they're here.