Skip to content

feat: limit number of function sources based on usage tier #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 24, 2025
Merged

feat: limit number of function sources based on usage tier #666

merged 4 commits into from
Oct 24, 2025

Conversation

@chase-crumbaugh
Copy link
Member

@chase-crumbaugh chase-crumbaugh commented Oct 23, 2025 •
edited
Loading

CleanShot 2025-10-23 at 14 55 21@2x CleanShot 2025-10-24 at 11 38 57@2x

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 85fe9a5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
gram Ready Ready Preview Comment Oct 24, 2025 6:40pm
gram-docs-redirect Ready Ready Preview Comment Oct 24, 2025 6:40pm
gram-landing-redirect Ready Ready Preview Comment Oct 24, 2025 6:40pm

@chase-crumbaugh chase-crumbaugh marked this pull request as ready for review October 23, 2025 21:57
@chase-crumbaugh chase-crumbaugh requested a review from a team as a code owner October 23, 2025 21:57
chase-crumbaugh
chase-crumbaugh commented Oct 23, 2025
View reviewed changes
server/internal/background/activities/deploy_function_runners.go Outdated

err := d.do(ctx, args)
if err != nil {
if logErr := deploymentsRepo.LogDeploymentEvent(ctx, deploymentsrepo.LogDeploymentEventParams{
Copy link
Member Author

@chase-crumbaugh chase-crumbaugh Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the placement of this will generally cause more errors to show up in user-facing logs

ryan-timothy-albert
ryan-timothy-albert reviewed Oct 24, 2025
View reviewed changes
cli/README.md
@@ -0,0 +1,22 @@
# Gram CLI
Copy link
Contributor

@ryan-timothy-albert ryan-timothy-albert Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful thanks

ryan-timothy-albert
ryan-timothy-albert approved these changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@ryan-timothy-albert ryan-timothy-albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me. Extensible too with Validate becoming its own activity

ryan-timothy-albert
ryan-timothy-albert reviewed Oct 24, 2025
View reviewed changes
server/internal/background/deployments.go
err = workflow.ExecuteActivity(
ctx,
a.ProvisionFunctionsAccess,
validationErr := workflow.ExecuteActivity(
Copy link
Contributor

@ryan-timothy-albert ryan-timothy-albert Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It totally should, but can you just double check in a local test that the status gets moved to failed.

Copy link
Member Author

@chase-crumbaugh chase-crumbaugh Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep i did

@chase-crumbaugh chase-crumbaugh merged commit b0009a4 into main Oct 24, 2025
23 checks passed
@chase-crumbaugh chase-crumbaugh deleted the chase/functions-limits branch October 24, 2025 19:29
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryan-timothy-albert ryan-timothy-albert ryan-timothy-albert approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chase-crumbaugh @ryan-timothy-albert