Security: Git token persisted in local config via URL rewrite may leak credentials#2018
Open
tuanaiseo wants to merge 1 commit into
Conversation
The GitHub access token is embedded directly into a rewritten URL and stored in repository-local git config (`url.<auth>.insteadOf`). This persists secrets in plaintext on disk and increases exposure via accidental config dumps, debugging output, backups, or compromised workspace reads. Affected files: auth.go Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The GitHub access token is embedded directly into a rewritten URL and stored in repository-local git config (
url.<auth>.insteadOf). This persists secrets in plaintext on disk and increases exposure via accidental config dumps, debugging output, backups, or compromised workspace reads.Severity:
highFile:
internal/git/auth.goSolution
Avoid writing tokens to git config. Prefer ephemeral auth mechanisms (
GIT_ASKPASS, credential helpers with scoped lifetime, or in-memory command env). If persistence is unavoidable, scrub config after use and mask secrets in all logs.Changes
internal/git/auth.go(modified)Testing