fix: remove tauri::ipc::Channel type from generated type set #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After collecting types from all the commands, make sure to remove the type for `tauri::ipc::Channel` as it may be present if any command took the channel as argument. Until this addition the user would generate the TAURI_CHANNEL type in their bindings if they called `.events()` and then `.commands()` in this order. The call to `.events()` tried to remove this type, but it got added later in the call to `.commands()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After collecting types from all the commands, make sure to remove the type for
tauri::ipc::Channelas it may be present if any command took the channel as argument.Until this addition the user would generate the TAURI_CHANNEL type in their bindings if they called
.events()and then.commands()in this order.The call to
.events()tried to remove this type, but it got added later in the call to.commands().this fixes: #171