Escape text in AnsiMarkupSegment.ToString()#2055
Merged
patriksvensson merged 1 commit intospectreconsole:mainfrom Mar 17, 2026
Merged
Escape text in AnsiMarkupSegment.ToString()#2055patriksvensson merged 1 commit intospectreconsole:mainfrom
patriksvensson merged 1 commit intospectreconsole:mainfrom
Conversation
AnsiMarkupSegment stores parsed (unescaped) text, but ToString() inserted it directly into markup output without re-escaping square brackets. This caused SelectionPrompt with EnableSearch() to crash when any choice contained brackets (e.g. [Prod]), because the search highlighting split escaped bracket sequences into invalid markup. Fixes spectreconsole#2054 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
patriksvensson
approved these changes
Mar 17, 2026
Contributor
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AnsiMarkupSegmentstores parsed (unescaped) text in itsTextproperty, butToString()inserted it directly into markup output without re-escaping square brackets. This causedSelectionPromptwithEnableSearch()to crash when any choice contained brackets (e.g.[Prod]), because the search highlighting split escaped bracket sequences into invalid markup.Fix
Escape the
Textproperty inToString()before inserting it into markup output, for both styled and plain segments.Tests
AnsiMarkupTests.cscovering escaped brackets inHighlight()SelectionPromptTests.csfor search with bracketed choicesFixes #2054