Skip to content

Fix infinite rebuild loop with polling-based file watching #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bizordec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix infinite rebuild loop with polling-based file watching #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sphinx_autobuild/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

import watchfiles
from starlette.websockets import WebSocket
from watchfiles import Change

if TYPE_CHECKING:
import os
Expand Down Expand Up @@ -51,7 +52,10 @@ async def main(self) -> None:
async def watch(self) -> None:
async for changes in watchfiles.awatch(
*self.paths,
watch_filter=lambda _, path: not self.ignore(path),
watch_filter=lambda change, path: (
(change != Change.modified or Path(path).is_file())
and not self.ignore(path)
),
):
changed_paths = [Path(path).resolve() for (_, path) in changes]
with ProcessPoolExecutor() as pool:
Expand Down
Loading