-
-
Notifications
You must be signed in to change notification settings - Fork 235
feat(snippets): gawr gura karaoke #1012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PiggMelonie
wants to merge
5
commits into
spicetify:main
Choose a base branch
from
PiggMelonie:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−0
Open
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1f98361
feat(snippets): add gura karaoke cover
PiggMelonie ae58e16
Update snippets.json
PiggMelonie 0dc6e16
Delete resources/assets/snippets/gurakaraoke.png
PiggMelonie fe2038c
feat(snippets): add gawr gura karaoke preview
PiggMelonie a1be630
Update snippets.json
PiggMelonie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The preview should be taken from the spotify client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for trying to do all this without really getting what to do, ive never attempted something like this. how would i upload the code to the client to be able to test it beforehand and take the preview?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marketplace -> Snippets tab -> Click
Add CSSbutton -> Paste the string fromcodeto it and save it with some name then enable itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg i didnt know i could do that the whole time. for like the last 12 hours ive been trying to mimic how all the requests are and trying to figure out what a pull request was and what stuff i had to edit. i thought for snippets id have to upload them to the marketplace for me to be able to even use them. again im super sorry about closing it over and over, my worst fear was that people would actually get notified of that, because i wasnt sure if they did. since ive already spent this long ill try my best to finish this pull anyways in case someone else wants to use it