Enhance VestingManager Functionality and Testing #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
VestingManager Contract Improvements
computeReleasableAmount
from public to internal for better encapsulation.initialize
function visibility frompublic
toexternal
for upgrade safetyinitializeV2
function inXXXVestingManagerV2
to properly initialize parent contractsNew Test Coverage
Testing
All tests are now passing:
Impact
This change ensures:
Related Issues
Fixes the upgrade safety issues in the VestingManager and TokenVault contracts while adding significant test coverage improvements.