Skip to content

readme & setup: simplify the run command and fix an error in setup-linux.sh #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2024
Merged

readme & setup: simplify the run command and fix an error in setup-linux.sh #184

merged 1 commit into from
Sep 10, 2024

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Sep 10, 2024

  1. change make run-spin to make run
  2. fix an error encountered in setup-linux.sh

@Mossaka Mossaka merged commit 8c36933 into main Sep 10, 2024
8 checks passed
@Mossaka Mossaka deleted the setup branch September 10, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@radu-matei radu-matei radu-matei approved these changes

@kate-goldenring kate-goldenring Awaiting requested review from kate-goldenring kate-goldenring is a code owner

@jsturtevant jsturtevant Awaiting requested review from jsturtevant jsturtevant is a code owner

@devigned devigned Awaiting requested review from devigned devigned is a code owner

+1 more reviewer

@rajatjindal rajatjindal rajatjindal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Mossaka @rajatjindal @radu-matei @Copilot