Skip to content

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Dec 13, 2024

Closes #249

esac

kubectl delete -f "tests/workloads-common" --wait --timeout 60s --ignore-not-found=true
kubectl delete -f "tests/workloads-pushed-using-docker-build-push" --wait --timeout 60s --ignore-not-found=true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
kubectl delete -f "tests/workloads-pushed-using-docker-build-push" --wait --timeout 60s --ignore-not-found=true
kubectl delete -f "$TESTS_PATH/tests/workloads-pushed-using-docker-build-push" --wait --timeout 60s --ignore-not-found=true

kubectl delete -f tests/workloads-common --wait --timeout 60s --ignore-not-found=true
kubectl delete -f tests/workloads-pushed-using-docker-build-push --wait --timeout 60s --ignore-not-found=true
kubectl delete -f tests/workloads-pushed-using-spin-registry-push --wait --timeout 60s --ignore-not-found=true
case "$1" in
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This highlights that it would be nice to have all the tests in one directory regardless of the K8s runtime rather than duplicating


sudo chmod 644 /etc/rancher/k3s/k3s.yaml
sudo cp /etc/rancher/k3s/k3s.yaml $HOME/.kube/k3s.yaml
export KUBECONFIG=$HOME/.kube/k3s.yaml
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting wont live outside this script. We likely need to set that before executing the tests in whatever shell does that or chang ethis to cp /etc/rancher/k3s/k3s.yaml $HOME/.kube/config

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's a good point

…v var 'SPIN_TEST_PORT'

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Moved install-k3s.sh from tests/k3s to scripts directory
* Updated install-k3s.sh script to set KUBECONFIG directly to /etc/rancher/k3s/k3s.yaml

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
- Replaced with a single `build-and-push-images.sh` script.
  - Support for both Spin and Docker build workflows with the `--spin`, `--docker`, and `--both` options.
- Added parallel processing for building and pushing images.

Signed-off-by: Jiaxiao (mossaka) Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integration test should add k3s tests

3 participants