-
Notifications
You must be signed in to change notification settings - Fork 19
update hono templates to addres deprecation #377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update hono templates to addres deprecation #377
Conversation
Signed-off-by: Karthik Ganeshram <[email protected]>
Signed-off-by: Karthik Ganeshram <[email protected]>
// For Hono documentation refer to https://hono.dev/docs/ | ||
{% when "hono" %}// For Hono documentation refer to https://hono.dev/docs/ | ||
import { Hono } from 'hono'; | ||
import { fire } from "hono/service-worker"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { fire } from "hono/service-worker"; | |
import { fire } from 'hono/service-worker'; |
{% when "hono" %}// For Hono documentation refer to https://hono.dev/docs/ | ||
import { Hono } from 'hono'; | ||
import type { Context, Next } from 'hono' | ||
import { fire } from "hono/service-worker"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { fire } from "hono/service-worker"; | |
import { fire } from 'hono/service-worker'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two suggestions, other than that it looks great
Signed-off-by: Karthik Ganeshram <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There is a deprecation notice on
app.fire
from hono, and this PR addresses that.