Skip to content

Conversation

karthik2804
Copy link
Collaborator

There is a deprecation notice on app.fire from hono, and this PR addresses that.

Signed-off-by: Karthik Ganeshram <[email protected]>
// For Hono documentation refer to https://hono.dev/docs/
{% when "hono" %}// For Hono documentation refer to https://hono.dev/docs/
import { Hono } from 'hono';
import { fire } from "hono/service-worker";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { fire } from "hono/service-worker";
import { fire } from 'hono/service-worker';

{% when "hono" %}// For Hono documentation refer to https://hono.dev/docs/
import { Hono } from 'hono';
import type { Context, Next } from 'hono'
import { fire } from "hono/service-worker";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
import { fire } from "hono/service-worker";
import { fire } from 'hono/service-worker';

Copy link
Contributor

@ThorstenHans ThorstenHans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two suggestions, other than that it looks great

Copy link
Contributor

@ThorstenHans ThorstenHans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karthik2804 karthik2804 merged commit 020b916 into spinframework:main Sep 10, 2025
11 checks passed
@karthik2804 karthik2804 deleted the update_hono_templates branch September 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants