build_tool: update cjs to v0.19.0 and bump package version #378
Conversation
karthik2804
force-pushed
the
build_tools/update_cjs
branch
from
1c3a246 to
9e1d0e0
Compare
Signed-off-by: Karthik Ganeshram <[email protected]>
karthik2804
force-pushed
the
build_tools/update_cjs
branch
from
9e1d0e0 to
da0465f
Compare
I think the best thing for now would be to make it a hard error instead of a warning: we shouldn't just silently build something with very different properties from what the user expected.
Given that we've never documented this, I think I agree that it's okay not to treat this as a breaking change, yeah. Over in CJS, we decided that it needs to be a breaking change, but there it was fully documented, so the situation was different. |
packages/build-tools/src/index.ts
Outdated
| console.warn( | ||
| 'Warning: AOT compilation is temporarily disabled due to issues with componentize-js. Proceeding without AOT. It may be removed in future releases.', | ||
| ); | ||
| CliArgs.aot = false; |
There was a problem hiding this comment.
As mentioned, I think we should make this a hard error, not a warning.
| console.warn( | |
| 'Warning: AOT compilation is temporarily disabled due to issues with componentize-js. Proceeding without AOT. It may be removed in future releases.', | |
| ); | |
| CliArgs.aot = false; | |
| throw new Error( | |
| 'AOT compilation is currently unavailable. Remove the `aot` option to proceed.', | |
| ); |
Additionally, I think we should add a hidden: true field to the yargs options for aot over in cli.ts.
There was a problem hiding this comment.
Between this option and potentially just removing the option. Do you have a preference?
There was a problem hiding this comment.
I think this option would be better: we don't know if someone looked at the --help output or the source and is using this in the wild after all. In that case, getting an explanation is definitely better than the option just disappearing.
There was a problem hiding this comment.
Done will update.
Signed-off-by: Karthik Ganeshram <[email protected]>
2 participants
Bumps ComponentizeJS which brings in a newer build of StarlingMonkey but we loose
aot. I have currently not removed the option but just print a warning and continue with building without it. If there are strong preferences, I am happy to delete it.It will be a breaking change, strictly speaking, but I do not think
aothas been advertised in the Spin docs, and I'm also not sure if it is widely used.