Skip to content

actually check in simplified runtime arg creation #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 21, 2025
Merged

actually check in simplified runtime arg creation #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/build-tools/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function getCliArgs(): CliArgs {
type: 'boolean',
})
.option('initLocation', {
describe: 'Location during top level initialization',
describe: 'URL used for the "Location" builtin during top level initialization',
type: 'string',
})
.argv as CliArgs;
Expand Down
13 changes: 6 additions & 7 deletions packages/build-tools/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@ async function main() {
let CliArgs = getCliArgs();
let src = CliArgs.input;
let outputPath = CliArgs.output;
let runtimeArgs = [
CliArgs.debug && '--enable-script-debugging',
CliArgs.initLocation && `--init-location ${CliArgs.initLocation}`
].filter(Boolean).join(' ');
let runtimeArgs = []
CliArgs.debug && runtimeArgs.push('--enable-script-debugging');
CliArgs.initLocation && runtimeArgs.push(`--init-location ${CliArgs.initLocation}`);

// generate wit world string
let wasiDeps = getPackagesWithWasiDeps(process.cwd(), new Set(), true);
Expand Down Expand Up @@ -64,7 +63,7 @@ async function main() {

let inlineWitChecksum = await calculateChecksum(inlineWit);
// Small optimization to skip componentization if the source file hasn't changed
if (!(await ShouldComponentize(src, outputPath, componentizeVersion, runtimeArgs, inlineWitChecksum))) {
if (!(await ShouldComponentize(src, outputPath, componentizeVersion, runtimeArgs.join(" "), inlineWitChecksum))) {
console.log(
'No changes detected in source file and target World. Skipping componentization.',
);
Expand Down Expand Up @@ -99,7 +98,7 @@ async function main() {
sourcePath: precompiledSourcePath,
// @ts-ignore
witWorld: inlineWit,
runtimeArgs,
runtimeArgs: runtimeArgs.join(" "),
enableAot: CliArgs.aot,
});

Expand All @@ -110,7 +109,7 @@ async function main() {
getBuildDataPath(src),
await calculateChecksum(await readFile(src)),
componentizeVersion,
runtimeArgs,
runtimeArgs.join(" "),
inlineWitChecksum,
);

Expand Down