Add support for WASI P3 #87
Conversation
|
cc/ @alexcrichton @tschneidereit for comments on the general shape of the upstreamable bits and possible next steps on where this could live. |
Signed-off-by: Brian Hardock <[email protected]>
There was a problem hiding this comment.
I don't feel able to comment on the implementation, although what I saw looked very cool - the same kind of "wow this is going to be super convenient" as some of Ryan's early work on the Spin HTTP SDK.
I had some surface level nits and suggestions but in terms of the overall stuff it looks great to me but definitely needs other eyes on it.
|
Do we want to more-explicitly frame this initial implementation as experimental/unstable (feature flag, |
|
This commit eliminates the |
fibonacci1729
force-pushed
the
wasip3
branch
2 times, most recently
from
f064bcc to
3dc8d5b
Compare
fibonacci1729
force-pushed
the
wasip3
branch
2 times, most recently
from
4e09979 to
0c104dc
Compare
|
Once bytecodealliance/wasi-rs#126 lands I'll remove the |
Signed-off-by: Brian Hardock <[email protected]>
|
|
||
| impl<T: http_body::Body> IntoResponse for (http::StatusCode, T) { | ||
| fn into_response(self) -> HttpResult<types::Response> { | ||
| unreachable!() |
There was a problem hiding this comment.
Is this intentional? Using unreachable! rather than todo!() makes me assume so but maybe add a comment on why it is unreachable?
There was a problem hiding this comment.
Oh this one slipped by! Ill fix, thanks for calling it out!
| /// The macro expands into a module containing a `Spin` struct that implements the | ||
| /// WASI `http.handler/Guest` interface, wiring the annotated function as the | ||
| /// handler’s entrypoint. This allows the function to be invoked automatically | ||
| /// by the Spin runtime when HTTP requests are received. |
There was a problem hiding this comment.
Nit: we should have an # Example section showing this macro in use.
| Error::Other(e) => write!(f, "{e}"), | ||
| Error::Response(e) => match http::StatusCode::from_u16(e.get_status_code()) { | ||
| Ok(status) => write!(f, "{status}"), | ||
| Err(e) => write!(f, "{e}"), |
There was a problem hiding this comment.
I'm not sure "{e}" will show a good error message. Perhaps we hardcode it to "invalid status code"?
There was a problem hiding this comment.
Perhaps even "invalid status code {}", e.get_status_code()? (With e not shadowed in the match arm, obvs)
There was a problem hiding this comment.
This code is already in the process of being upstreamed: bytecodealliance/wasi-rs#126
5 participants
Moves the contents of the prototype repo into the sdk.
The additions are factored into 3 new crates:
The contents of these repo are accessible via the
spin_sdkthrough thehttp_wasip3module.Draft for now while I make a final pass to eliminate low hanging TODOs. Nevertheless requesting reviews now.