Skip to content

Utf8view #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lizardoluis wants to merge 3 commits into from
Closed

Utf8view #1

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2c5252
feat: add support for Utf8View in ScalarValue and ArrowDataType
lizardoluis Mar 19, 2025
83dcc43
Merge branch 'main' of ssh://github.com/splitgraph/delta-rs into utf8…
lizardoluis Mar 19, 2025
7e5a6ef
fix: remove Utf8View handling from get_null_of_arrow_type and ScalarExt
lizardoluis Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/core/src/delta_datafusion/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,7 @@ fn _arrow_schema(snapshot: &Snapshot, wrap_partitions: bool) -> DeltaResult<Arro
// Only dictionary-encode types that may be large
// // https://github.com/apache/arrow-datafusion/pull/5545
ArrowDataType::Utf8
| ArrowDataType::Utf8View
| ArrowDataType::LargeUtf8
| ArrowDataType::Binary
| ArrowDataType::LargeBinary => {
Expand Down Expand Up @@ -1087,6 +1088,7 @@ pub(crate) fn get_null_of_arrow_type(t: &ArrowDataType) -> DeltaResult<ScalarVal
}
ArrowDataType::LargeBinary => Ok(ScalarValue::LargeBinary(None)),
ArrowDataType::Utf8 => Ok(ScalarValue::Utf8(None)),
ArrowDataType::Utf8View => Ok(ScalarValue::Utf8View(None)),
ArrowDataType::LargeUtf8 => Ok(ScalarValue::LargeUtf8(None)),
ArrowDataType::Decimal128(precision, scale) => Ok(ScalarValue::Decimal128(
None,
Expand Down Expand Up @@ -1120,7 +1122,6 @@ pub(crate) fn get_null_of_arrow_type(t: &ArrowDataType) -> DeltaResult<ScalarVal
| ArrowDataType::Interval(_)
| ArrowDataType::RunEndEncoded(_, _)
| ArrowDataType::BinaryView
| ArrowDataType::Utf8View
| ArrowDataType::LargeListView(_)
| ArrowDataType::ListView(_)
| ArrowDataType::Map(_, _) => Err(DeltaTableError::Generic(format!(
Expand Down
Loading