refactor: update alerts approach to newest splunk approach #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanm-crest
changed the title
Code Coverage 🎉
|
| type="text" | ||
| name="action.{{ mod_alert.short_name }}.param.{{ param.name }}" | ||
| id="{{ mod_alert.short_name }}_{{ param.name }}" | ||
| /> |
There was a problem hiding this comment.
shouldn't we add {{ expand_ctrl_props(param) }}
| <splunk-radio-input | ||
| name="action.{{ mod_alert.short_name }}.param.{{ param.name }}" | ||
| id="{{ mod_alert.short_name }}_{{ param.name }}" | ||
| value="{{ param.default_value }}" |
There was a problem hiding this comment.
shouldn't we add {{ expand_ctrl_props(param) }}
| <textarea | ||
| name="action.{{ mod_alert.short_name }}.param.{{ param.name }}" | ||
| id="{{ mod_alert.short_name }}_{{ param.name }}" | ||
| ></textarea> |
There was a problem hiding this comment.
shouldn't we add {{ expand_ctrl_props(param) }} it might be useful for other text area properties like max length
| b"".join(actual_file_lines) | ||
| if actual_file_lines and isinstance(actual_file_lines[0], bytes) | ||
| else b"" | ||
| ) |
There was a problem hiding this comment.
nice catch, I assume here was issue, right?
As before there was comparision of the same variables
There was a problem hiding this comment.
yess, now it would be checking the bytes so that extra whitespace issue will resolved.
|
No further requirement. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-78947
PR Type
What kind of change does this PR introduce?
Summary
Changes
Introduce new Splunk approaches to create custom alerts actions.
User experience
Users can see the new Splunk based component for custom alerts actions.
Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear