Skip to content

refactor: introduce vite as build tool #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2025

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Apr 22, 2025

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

part of #1657
introducing Vite as a package build tool

User experience

N/A - should stay the same

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@soleksy-splunk
Copy link
Contributor Author

the CI / compliance-copyrights (pull_request) fails due to ui/babel.config.cjs being present instead of ui/babel.config.js (.cjs instead of .js). I'm not adding it for licensing as it is removed in vitest PR

@soleksy-splunk soleksy-splunk marked this pull request as ready for review April 23, 2025 10:48
@soleksy-splunk soleksy-splunk requested review from a team as code owners April 23, 2025 10:48
@soleksy-splunk soleksy-splunk changed the title chore: introduce vite as build tool refactor: introduce vite as build tool Apr 23, 2025
@rohanm-crest
Copy link
Contributor

Everything LGTM, just a minor changes

@soleksy-splunk soleksy-splunk force-pushed the chore/introduce-vite-as-build-tool branch from 365ac3f to ca5e96f Compare May 5, 2025 17:32
@soleksy-splunk soleksy-splunk force-pushed the chore/introduce-vite-as-build-tool branch from 0fd36d7 to 6b39912 Compare May 5, 2025 17:56
rohanm-crest
rohanm-crest previously approved these changes May 6, 2025
@soleksy-splunk soleksy-splunk merged commit 2f51481 into develop May 9, 2025
93 of 94 checks passed
@soleksy-splunk soleksy-splunk deleted the chore/introduce-vite-as-build-tool branch May 9, 2025 08:50
@github-actions github-actions bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants