Skip to content

fix: custom tab without entity error #1718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 29, 2025
Merged

Conversation

kkedziak-splunk
Copy link
Contributor

@kkedziak-splunk kkedziak-splunk commented Apr 30, 2025

Issue number: ADDON-80104

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Made entity as an optional attribute while accessing it from globalConfig. Also updated the documentation and added a customTab without entities in _everything add-on.

User experience

Now users can create their customTab without defining entity.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

@kkedziak-splunk kkedziak-splunk requested a review from a team as a code owner April 30, 2025 10:46
@kkedziak-splunk kkedziak-splunk changed the title fix: fix custom tab without entity error fix: custom tab without entity error Apr 30, 2025
@hetangmodi-crest hetangmodi-crest requested a review from a team as a code owner April 30, 2025 12:10
@pull-request-size pull-request-size bot added size/L and removed size/M labels Apr 30, 2025
@hetangmodi-crest hetangmodi-crest self-assigned this May 2, 2025
@hetangmodi-crest hetangmodi-crest marked this pull request as draft May 5, 2025 05:38
@hetangmodi-crest hetangmodi-crest marked this pull request as ready for review May 6, 2025 05:43
@sgoral-splunk sgoral-splunk self-requested a review May 23, 2025 07:39
Copy link

Code Coverage ⚠️

Type PR Develop Change Status
Line Coverage 88.21% 88.27% 0.06% 🔴 Decreased
Branch Coverage 81.79% 81.92% 0.13% 🔴 Decreased

@hetangmodi-crest hetangmodi-crest merged commit 9c38fd4 into develop May 29, 2025
94 checks passed
@hetangmodi-crest hetangmodi-crest deleted the fix/custom-tab-error branch May 29, 2025 11:14
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants