-
Notifications
You must be signed in to change notification settings - Fork 27
fix: custom tab without entity error #1718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
splunk_add_on_ucc_framework/commands/openapi_generator/ucc_to_oas.py
Outdated
Show resolved
Hide resolved
splunk_add_on_ucc_framework/generators/conf_files/create_settings_conf.py
Outdated
Show resolved
Hide resolved
13 tasks
splunk_add_on_ucc_framework/generators/conf_files/create_settings_conf.py
Outdated
Show resolved
Hide resolved
kkedziak-splunk
commented
May 20, 2025
splunk_add_on_ucc_framework/commands/rest_builder/global_config_builder_schema.py
Outdated
Show resolved
Hide resolved
kkedziak-splunk
commented
May 20, 2025
splunk_add_on_ucc_framework/commands/rest_builder/global_config_builder_schema.py
Outdated
Show resolved
Hide resolved
kkedziak-splunk
commented
May 20, 2025
splunk_add_on_ucc_framework/generators/conf_files/create_settings_conf.py
Show resolved
Hide resolved
kkedziak-splunk
commented
May 20, 2025
kkedziak-splunk
commented
May 20, 2025
kkedziak-splunk
commented
May 20, 2025
kkedziak-splunk
commented
May 20, 2025
sgoral-splunk
approved these changes
May 23, 2025
Code Coverage
|
Type | PR | Develop | Change | Status |
---|---|---|---|---|
Line Coverage | 88.21% | 88.27% | 0.06% | 🔴 Decreased |
Branch Coverage | 81.79% | 81.92% | 0.13% | 🔴 Decreased |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON-80104
PR Type
What kind of change does this PR introduce?
Summary
Changes
Made
entity
as an optional attribute while accessing it from globalConfig. Also updated the documentation and added a customTab without entities in_everything
add-on.User experience
Now users can create their
customTab
without defining entity.Checklist
If an item doesn't apply to your changes, leave it unchecked.
Review
Tests
See the testing doc.
Demo/meeting:
Reviewers are encouraged to request meetings or demos if any part of the change is unclear