Skip to content

ci(readiness): add readiness validation and guidance - #2038

Draft
artemrys wants to merge 3 commits into
developfrom
arys/ucc-readiness-uplift
Draft

ci(readiness): add readiness validation and guidance#2038
artemrys wants to merge 3 commits into
developfrom
arys/ucc-readiness-uplift

Conversation

@artemrys

@artemrys artemrys commented May 7, 2026

Copy link
Copy Markdown
Member

Issue number: N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Add explicit naming and complexity enforcement, a hardened changed-line coverage workflow, repo-local agent skills, and contributor guidance for secret handling and diagnostic redaction.

User experience

N/A

Checklist

If an item doesn't apply to your changes, leave it unchecked.

Review

  • self-review - I have performed a self-review of this change according to the development guidelines
  • Changes are documented. The documentation is understandable, examples work (more info)
  • PR title and description follows the contributing principles
  • meeting - I have scheduled a meeting or recorded a demo to explain these changes (if there is a video, put a link below and in the ticket)

Tests

See the testing doc.

  • Unit - tests have been added/modified to cover the changes
  • Smoke - tests have been added/modified to cover the changes
  • UI - tests have been added/modified to cover the changes
  • coverage - I have checked the code coverage of my changes (see more)

Demo/meeting:

Reviewers are encouraged to request meetings or demos if any part of the change is unclear

srv-rr-github-token and others added 2 commits May 7, 2026 18:35
# [6.4.0](v6.3.0...v6.4.0) (2026-04-24)

### Bug Fixes

* add x-access-token prefix for GitHub App token in URL substitution ([3243a22](3243a22))
* **app-conf:** preserve source is_visible setting ([#2028](#2028)) ([33c287a](33c287a)), closes [#1953](#1953)
* **schema:** require access token endpoint for oauth client credentials ([#2030](#2030)) ([bccf288](bccf288)), closes [#1950](#1950)

### Features

* **nav:** add configurable default.xml nav color ([#2024](#2024)) ([38a26ea](38a26ea)), closes [#2021](#2021)
* **ui:** wire custom favicon contract ([#2032](#2032)) ([514181c](514181c)), closes [#1730](#1730)
* **validate:** expose detailed AppInspect output options ([#2025](#2025)) ([78f3500](78f3500)), closes [#1976](#1976) [hi#level](https://github.com/hi/issues/level)
Add explicit naming and complexity enforcement, a hardened changed-line coverage workflow, repo-local agent skills, and contributor guidance for secret handling and diagnostic redaction.
@artemrys

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ba9c9d3028

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui/.eslintrc.cjs
Comment on lines +43 to +45
selector: 'variableLike',
format: ['camelCase'],
leadingUnderscore: 'allow',

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Allow PascalCase for named React function components

The new @typescript-eslint/naming-convention rule applies variableLike as camelCase only, and variableLike includes named functions, so existing PascalCase component declarations now violate lint (for example function DashboardPage() and many similar function <ComponentName>() declarations under ui/src). This makes yarn run lint fail after this change even without touching source code, which can block CI/release jobs that depend on UI lint passing. Add a function-specific exception (e.g., allow PascalCase for selector: 'function') or narrow variableLike so component function names remain valid.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants