Skip to content

Add contentctl_library_version contentctl.yml field#336

Closed
pyth0n1c wants to merge 10 commits intomainfrom
enforce_contentctl_version
Closed

Add contentctl_library_version contentctl.yml field#336
pyth0n1c wants to merge 10 commits intomainfrom
enforce_contentctl_version

Conversation

@pyth0n1c
Copy link
Copy Markdown
Contributor

@pyth0n1c pyth0n1c commented Dec 7, 2024

Begin tracking the version of contentctl used to build a specific repo state and enforcing it
so that builds and other operations are repeatable.

diffing the changes easier
@pyth0n1c pyth0n1c changed the title Most of the way there but Add contentctl_library_version contentctl.yml field Dec 9, 2024
pyth0n1c and others added 8 commits December 12, 2024 15:27
contentctl is used for
running contentctl ops
make sure testing against escu
uses the current version for enforcement,
overwriting what may be in
contentctl.yml
explicitly over-ridden
needing to call expllicitly
josehelps
josehelps previously approved these changes Feb 28, 2025
Copy link
Copy Markdown
Contributor

@josehelps josehelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pyth0n1c pyth0n1c changed the base branch from contentctl_5 to main April 30, 2025 13:27
@pyth0n1c pyth0n1c dismissed josehelps’s stale review April 30, 2025 13:27

The base branch was changed.

@pyth0n1c
Copy link
Copy Markdown
Contributor Author

Closing out this PR. Instead of building all of this as another check and feature into contentctl, we simply included a requirements.txt in the security_content repo. Other users of contentctl should take a similar approach for more deterministic builds:
https://github.com/splunk/security_content/blob/develop/requirements.txt

@pyth0n1c pyth0n1c closed this Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants