Skip to content

Fix Reported Issues #3529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix Reported Issues #3529

wants to merge 1 commit into from

Conversation

nasbench
Copy link
Contributor

@nasbench nasbench commented May 19, 2025

This PR fixes the following reported issues.

The fixes are straight forward as most of the issues have correctly pointed the bugs accurately.

@tccontre can you please look at the fix for Ping Sleep Batch Command. I removed the macro as the analytic is looking for commands that are linked after a ping, and added a & and other variants of the strings.

@nasbench nasbench requested a review from tccontre May 19, 2025 21:24
@nasbench nasbench modified the milestone: v5.6.0 May 19, 2025
@tccontre
Copy link
Contributor

LGTM buddy! thank you.

Copy link
Contributor

@tccontre tccontre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants