renamed input parameter endpoint to api_version #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi team, |
Author
|
Hi @ayushghosh @JasonConger @nickshine @pellaredk, just checking in on this PR. Appreciate any feedback when you get a chance! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Microsoft Graph Security API exposes multiple resource endpoints (e.g., alerts, incidents), but currently, only alerts is supported in this implementation.
While reviewing the code related to issue #96, I noticed that the input parameter named endpoint is actually being used to specify the API version (e.g., v1.0), not the actual resource endpoint. This is a bit misleading in terms of naming.
In this pull request, I've renamed the endpoint parameter to api_version to better reflect its purpose.
As a follow-up, I plan to introduce a new parameter named endpoint to specify the actual resource (e.g., alerts, incidents), which will make the module more flexible and allow support for other Graph Security API endpoints in the future.