feat(examples): rename galileo -> splunk-ao in requirements files (HYBIM-823)#65
Conversation
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: request_changes — Rename is consistent, but the elastic app's requirements.in source was not updated, so the next pip-compile will revert the change.
General Comments
- 🟡 minor (other): Per the PR body,
splunk-aois not yet published to PyPI. Until it is, every example whose requirements now referencesplunk-aobecomes non-installable viapip install -r ...(and the openai-responses lockfile still pins the oldgalileo-core==3.84.0rather than thegalileo-core ^4.3.0that splunk-ao requires). This is an expected transitional state, but consider gating this merge on publication, or noting in the affected READMEs that installation requires the package to be published first, so users don't hit install failures in the interim.
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
examples/agent/langgraph-telecom-agent/pyproject.toml:2-2: Several example project names/descriptions still referencegalileo(e.g.name = "galileo-langgraph-telecom-agent"here and in langgraph-fsi-agent's before/after pyproject.toml). Out of scope for this dependency-rename PR, but worth a follow-up sweep for full branding consistency.
|
|
Thanks for the catch. Fixed in the latest commit. |
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: request_changes — Clean rename overall, but the test_setup.py change introduces a regression: importlib.import_module("splunk-ao") always fails since import name is splunk_ao.
Follow-ups
Suggested follow-up work that could be tracked as Shortcut stories:
examples/chatbot/basic-examples/package.json:3-3: package.json and package-lock.json still declare the npm dependency"galileo": "^1.2.0". This is a separate JS ecosystem package outside this PR's stated scope (Python requirements files), but if these basic-examples are meant to reflect the splunk-ao rename it should likely be updated or removed for consistency with the README'spip install ... splunk-aosnippet.examples/agent/startup-simulator-3000/test_setup.py:32-32: Pre-existing (not introduced by this PR):"python-dotenv"in required_packages also failsimport_modulesince its import name isdotenv. Worth fixing while touching this file sotest_dependencies()reports accurately.
… (HYBIM-823) Replace the galileo package with splunk-ao across all 23 examples/requirements.txt files. Extras (otel, openai, middleware) and galileo-core references unchanged. Version pins on galileo lines dropped as they reference old galileo releases.
…les README (HYBIM-823) openai-responses/pyproject.toml was the source-of-truth for the compiled requirements.txt — also rename galileo there. README in basic-examples had a pip install snippet still referencing galileo. Note: requirements.txt in openai-responses cannot be recompiled until splunk-ao is published to PyPI; the hand-edited lockfile entry will self-correct post-publish.
…deps (HYBIM-823) Six example sub-projects manage dependencies via pyproject.toml directly and were missed in the initial pass. Includes elevenlabs-chatbot whose requirements.txt was already updated.
…/requirements.in (HYBIM-823) requirements.in is the pip-compile source for requirements.txt — missing this would revert the rename on next pip-compile run.
…st_setup (HYBIM-823) Four additional files missed in the initial pass: - examples/templates.py (PEP 723 inline script deps) - examples/langgraph/with_openai.py (PEP 723 inline script deps) - examples/langgraph/basic_langgraph.py (PEP 723 inline script deps) - examples/agent/startup-simulator-3000/test_setup.py (runtime dep check)
9a513f5 to
c351f3d
Compare
|
Addressed all reviewer findings:
|
fercor-cisco
left a comment
There was a problem hiding this comment.
🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.
Verdict: approve — Mechanical galileo→splunk-ao rename; the one flagged runtime bug was fixed correctly via a superior approach, and no remaining correctness issues found.
General Comments
- 🟡 minor (design): After this rename, none of these examples'
pip install -r requirements.txt(oruv syncon the pyproject files) will succeed untilsplunk-aois published to PyPI — every example that previously installedgalileowill now fail resolution. The PR description acknowledges this for the openai-responses lockfile, but it applies to all 23 files. If this is intended to land ahead of publication, consider gating the merge on the PyPI release (or noting the dependency in the ticket) so the examples aren't left in a broken-to-run state in the interim.
There was a problem hiding this comment.
examples/agent/startup-simulator-3000/test_setup.py:17-17 (line not in diff)
🔵 nit (other): The new module-level from importlib.metadata import version import now coexists with the local version = sys.version_info here, which shadows it within this function. It's harmless (the local is only used inside test_python_version, and test_dependencies still resolves the module-level version), but the name collision is easy to misread. Consider renaming the local to py_version for clarity.
| py_version = sys.version_info | |
| if py_version.major < 3 or (py_version.major == 3 and py_version.minor < 8): | |
| print(f"❌ Python {py_version.major}.{py_version.minor} is too old. Need Python 3.8+") | |
| return False | |
| print(f"✅ Python {py_version.major}.{py_version.minor}.{py_version.micro} is compatible") |
🤖 Generated by Astra
There was a problem hiding this comment.
I'll create a Jira ticket for this.
Summary
galileopackage install tosplunk-aoacross all 23examples/requirements filesexamples/logging-samples/openai-responses/pyproject.toml(source-of-truth for that compiled lockfile)examples/chatbot/basic-examples/README.mdpip install snippetDetails
galileo[otel]→splunk-ao[otel],galileo[openai]→splunk-ao[openai],galileo[openai,middleware]→splunk-ao[openai,middleware]galileo-coreunchanged: separate external dep, not renamedsplunk-aorungalileo/simple-agent-frameworkgit URL inweather-vibes-agent/requirements.txtunchanged — different packageopenai-responses/requirements.txtis a uv-compiled lockfile. Thepyproject.tomlsource is fixed in this PR. The lockfile cannot be recompiled untilsplunk-aois published to PyPI; the hand-edited entry (splunk-ao, no version pin) will be replaced by a propersplunk-ao==<version>line on next recompile post-publish.Test plan
^galileolines remain in examples (excludinggalileo-coreandrungalileogit URLs)