Skip to content

feat(examples): rename galileo -> splunk-ao in requirements files (HYBIM-823)#65

Merged
etserend merged 5 commits into
mainfrom
HYBIM-823-update-examples-requirements
Jul 7, 2026
Merged

feat(examples): rename galileo -> splunk-ao in requirements files (HYBIM-823)#65
etserend merged 5 commits into
mainfrom
HYBIM-823-update-examples-requirements

Conversation

@etserend

@etserend etserend commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Renames the galileo package install to splunk-ao across all 23 examples/ requirements files
  • Updates examples/logging-samples/openai-responses/pyproject.toml (source-of-truth for that compiled lockfile)
  • Updates examples/chatbot/basic-examples/README.md pip install snippet

Details

  • Extras preserved: galileo[otel]splunk-ao[otel], galileo[openai]splunk-ao[openai], galileo[openai,middleware]splunk-ao[openai,middleware]
  • galileo-core unchanged: separate external dep, not renamed
  • Version pins dropped on hand-written files: the pinned versions referenced old galileo releases that have no meaning for splunk-ao
  • rungalileo/simple-agent-framework git URL in weather-vibes-agent/requirements.txt unchanged — different package
  • openai-responses/requirements.txt is a uv-compiled lockfile. The pyproject.toml source is fixed in this PR. The lockfile cannot be recompiled until splunk-ao is published to PyPI; the hand-edited entry (splunk-ao, no version pin) will be replaced by a proper splunk-ao==<version> line on next recompile post-publish.

Test plan

  • CI green
  • No ^galileo lines remain in examples (excluding galileo-core and rungalileo git URLs)

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: request_changes — Rename is consistent, but the elastic app's requirements.in source was not updated, so the next pip-compile will revert the change.

General Comments

  • 🟡 minor (other): Per the PR body, splunk-ao is not yet published to PyPI. Until it is, every example whose requirements now reference splunk-ao becomes non-installable via pip install -r ... (and the openai-responses lockfile still pins the old galileo-core==3.84.0 rather than the galileo-core ^4.3.0 that splunk-ao requires). This is an expected transitional state, but consider gating this merge on publication, or noting in the affected READMEs that installation requires the package to be published first, so users don't hit install failures in the interim.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

  • examples/agent/langgraph-telecom-agent/pyproject.toml:2-2: Several example project names/descriptions still reference galileo (e.g. name = "galileo-langgraph-telecom-agent" here and in langgraph-fsi-agent's before/after pyproject.toml). Out of scope for this dependency-rename PR, but worth a follow-up sweep for full branding consistency.

@fercor-cisco

Copy link
Copy Markdown
Collaborator

examples/rag/elastic-chatbot-rag-app/requirements.in:24 still has galileo — needs to be updated to splunk-ao to match the compiled requirements.txt, otherwise the next pip-compile run will revert the rename.

@etserend

etserend commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

examples/rag/elastic-chatbot-rag-app/requirements.in:24 still has galileo — needs to be updated to splunk-ao to match the compiled requirements.txt, otherwise the next pip-compile run will revert the rename.

Thanks for the catch. Fixed in the latest commit.

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: request_changes — Clean rename overall, but the test_setup.py change introduces a regression: importlib.import_module("splunk-ao") always fails since import name is splunk_ao.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

  • examples/chatbot/basic-examples/package.json:3-3: package.json and package-lock.json still declare the npm dependency "galileo": "^1.2.0". This is a separate JS ecosystem package outside this PR's stated scope (Python requirements files), but if these basic-examples are meant to reflect the splunk-ao rename it should likely be updated or removed for consistency with the README's pip install ... splunk-ao snippet.
  • examples/agent/startup-simulator-3000/test_setup.py:32-32: Pre-existing (not introduced by this PR): "python-dotenv" in required_packages also fails import_module since its import name is dotenv. Worth fixing while touching this file so test_dependencies() reports accurately.

Comment thread examples/agent/startup-simulator-3000/test_setup.py
etserend added 5 commits July 7, 2026 13:44
… (HYBIM-823)

Replace the galileo package with splunk-ao across all 23 examples/requirements.txt
files. Extras (otel, openai, middleware) and galileo-core references unchanged.
Version pins on galileo lines dropped as they reference old galileo releases.
…les README (HYBIM-823)

openai-responses/pyproject.toml was the source-of-truth for the compiled
requirements.txt — also rename galileo there. README in basic-examples had a
pip install snippet still referencing galileo.

Note: requirements.txt in openai-responses cannot be recompiled until splunk-ao
is published to PyPI; the hand-edited lockfile entry will self-correct post-publish.
…deps (HYBIM-823)

Six example sub-projects manage dependencies via pyproject.toml directly and were
missed in the initial pass. Includes elevenlabs-chatbot whose requirements.txt
was already updated.
…/requirements.in (HYBIM-823)

requirements.in is the pip-compile source for requirements.txt — missing this
would revert the rename on next pip-compile run.
…st_setup (HYBIM-823)

Four additional files missed in the initial pass:
- examples/templates.py (PEP 723 inline script deps)
- examples/langgraph/with_openai.py (PEP 723 inline script deps)
- examples/langgraph/basic_langgraph.py (PEP 723 inline script deps)
- examples/agent/startup-simulator-3000/test_setup.py (runtime dep check)
@etserend etserend force-pushed the HYBIM-823-update-examples-requirements branch from 9a513f5 to c351f3d Compare July 7, 2026 18:45
@etserend

etserend commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Addressed all reviewer findings:

  • Fixed requirements.in for rag/elastic-chatbot-rag-app (pip-compile source file, missed in initial pass)
  • Fixed PEP 723 inline script deps in templates.py, langgraph/with_openai.py, langgraph/basic_langgraph.py
  • Fixed agent/startup-simulator-3000/test_setup.py runtime dep check: replaced importlib.import_module("splunk-ao") with importlib.metadata.version("splunk-ao")import_module rejects hyphenated names, metadata.version accepts the distribution name directly
  • Ran full sweep with grep -r 'galileo' examples/ to confirm no remaining galileo package references in requirements files (only galileo-core deps and source import paths remain, both intentionally unchanged)
  • Rebased onto main after PR feat(tooling): bump ruff 0.9.7 -> 0.15.20 (HYBIM-777) #66 merged

@etserend etserend requested a review from fercor-cisco July 7, 2026 18:57

@fercor-cisco fercor-cisco left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Mechanical galileo→splunk-ao rename; the one flagged runtime bug was fixed correctly via a superior approach, and no remaining correctness issues found.

General Comments

  • 🟡 minor (design): After this rename, none of these examples' pip install -r requirements.txt (or uv sync on the pyproject files) will succeed until splunk-ao is published to PyPI — every example that previously installed galileo will now fail resolution. The PR description acknowledges this for the openai-responses lockfile, but it applies to all 23 files. If this is intended to land ahead of publication, consider gating the merge on the PyPI release (or noting the dependency in the ticket) so the examples aren't left in a broken-to-run state in the interim.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

examples/agent/startup-simulator-3000/test_setup.py:17-17 (line not in diff)

🔵 nit (other): The new module-level from importlib.metadata import version import now coexists with the local version = sys.version_info here, which shadows it within this function. It's harmless (the local is only used inside test_python_version, and test_dependencies still resolves the module-level version), but the name collision is easy to misread. Consider renaming the local to py_version for clarity.

Suggested change
py_version = sys.version_info
if py_version.major < 3 or (py_version.major == 3 and py_version.minor < 8):
print(f"❌ Python {py_version.major}.{py_version.minor} is too old. Need Python 3.8+")
return False
print(f"✅ Python {py_version.major}.{py_version.minor}.{py_version.micro} is compatible")

🤖 Generated by Astra

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll create a Jira ticket for this.

@etserend etserend merged commit c768d7c into main Jul 7, 2026
13 checks passed
@etserend etserend deleted the HYBIM-823-update-examples-requirements branch July 7, 2026 21:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants