Skip to content

ci: add lint workflow using ruff #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adityamehra wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ci: add lint workflow using ruff #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6f60c7
ci: add lint workflow using ruff
adityamehra Jun 8, 2026
b706645
ci(lint): pin ruff to 0.12.8 to match galileo-python lock file
adityamehra Jun 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions .github/workflows/ci-lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
name: CI - Lint

on:
push:
branches: [main]
pull_request:
branches: [main]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

env:
PYTHONUNBUFFERED: "1"
FORCE_COLOR: "1"

jobs:
lint:
name: Lint Code
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2

- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6
with:
python-version: '3.12'

- name: Install Ruff
run: |
python -m pip install --upgrade pip
pip install ruff==0.12.8

@fercor-cisco fercor-cisco Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 major (design): Ruff version drift across the repo will cause CI to disagree with local tooling. This workflow installs ruff==0.12.8, but .pre-commit-config.yaml pins ruff-pre-commit at v0.9.7 and pyproject.toml dev deps pin ruff = "^0.12.3". Because ruff format output and lint rule sets change between versions, a contributor who runs pre-commit (0.9.7) can produce code that fails ruff format --check/ruff check under 0.12.8 in CI even though they followed the project's hooks. Pin CI to the same ruff version the project uses (and ideally bump the pre-commit hook to match) so local and CI results are consistent.


- name: Run linting
run: ruff check .

@fercor-cisco fercor-cisco Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 major (bug): ruff check . will not reliably fail CI because the project's [tool.ruff] config sets fix = true (pyproject.toml line 120; the galileo-adk and galileo-a2a configs also set it). With fix = true, ruff check applies all fixable corrections to the files on disk and only reports/exits non-zero for the remaining unfixable violations. In CI the fixed files are discarded, so any auto-fixable lint error (unused imports, import sorting, many UP/SIM/RUF rules, etc.) is silently "fixed" in the ephemeral checkout and the job passes green — the opposite of what a lint gate should do. Use --no-fix so the check is read-only and fails on every violation.

Suggested change
run: ruff check .
run: ruff check --no-fix .


- name: Check formatting
run: ruff format --check .
Loading