fix(galileo-adk): Rebrand to SPLUNK_AO_* env vars and SplunkAO* classes and rename package to splunk-ao-adk and reset to v0.1.0

[adityamehra]

Context

Rebrand to SPLUNK_AO_* env vars and SplunkAO* classes
Rename package to splunk-ao-adk and reset to v0.1.0

Changes

galileo-adk/src/galileo_adk/

• Rename GalileoADKCallback -> SplunkAOADKCallback
• Rename GalileoADKObserver -> SplunkAOADKObserver
• Rename GalileoADKPlugin -> SplunkAOADKPlugin
• Rename GALILEO_* env vars -> SPLUNK_AO_* throughout callback.py, decorator.py, observer.py, plugin.py
• Update init.py exports to SplunkAO* names
• Update pyproject.toml: galileo dependency -> splunk-ao

src/splunk_ao/config.py

• Add ("SPLUNK_AO_API_URL", "GALILEO_API_URL") to _bridge_env_vars() so SPLUNK_AO_API_URL is correctly passed to galileo-core for self-hosted deployments

galileo-adk/pyproject.toml

• Rename package: galileo-adk → splunk-ao-adk
• Reset version: 2.0.1 → 0.1.0
• Update authors: Galileo Technologies Inc. → Splunk Inc.
• Update Repository URL: rungalileo/galileo-python → splunk/splunk-ao-python
• Replace runtime dependency: galileo → splunk-ao
• Update tool.uv.sources key: galileo → splunk-ao
• Replace dev dependency: galileo-core[testing] → splunk-ao[otel]
• Update semantic_release tag format: galileo-adk-v* → splunk-ao-adk-v*
• Update ruff.lint.isort.known-first-party: galileo → splunk_ao

galileo-adk/src/galileo_adk/__init__.py

• Reset __version__ from 2.0.1 → 0.1.0

galileo-adk/README.md

• Update package name heading, PyPI badges, license link, and pip install command to splunk-ao-adk
• Replace GalileoADK* class names with SplunkAOADK* in all code examples
• Replace GALILEO_* env vars -> SPLUNK_AO_* in configuration tables
• Update brand mentions (Galileo -> Splunk AO)

.github/workflows/ci-tests-splunk-ao-adk.yaml

• Add pipeline to run unit tests during ci

Test plan

• uv sync completes without errors
• Package builds cleanly: uv build
• pip install splunk-ao-adk resolves after publishing to PyPI

[fercor-cisco]

Running an automated review agent.

[fercor-cisco]

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: request_changes — The rebrand renames are consistent, but the adk now pins splunk-ao>=2.0.0,<3.0.0 while the root splunk-ao package was reset to 0.1.0, making the published package unresolvable; the dev-dep swap also drops the galileo-core[testing] fixtures the tests depend on.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

• src/splunk_ao/config.py:47-47: The new SPLUNK_AO_API_URL -> GALILEO_API_URL bridge entry is correct and consistent with the rest of _BRIDGE, but there is no unit test covering it (test_config.py only asserts the default api_url). Consider adding a small test that sets SPLUNK_AO_API_URL and asserts GALILEO_API_URL is populated (and that an explicit GALILEO_API_URL is not overridden), to guard the bridge against regressions.

[adityamehra]

Addressing review comments from @fercor-cisco (commit bcdc1a5):

Comment 1 — runtime dep version range (line 18)
Fixed: splunk-ao>=2.0.0,<3.0.0 → splunk-ao>=0.1.0,<1.0.0 to align with the actual package version.

Comment 2 — dev dep version + galileo-core[testing] (line 140)
Fixed: lowered splunk-ao[otel] to >=0.1.0,<1.0.0 and restored galileo-core[testing]>=3.82.0 alongside it so the mock_request autouse fixture (used in conftest.py and mocks.py) remains available.

[fercor-cisco]

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: request_changes — The rebrand left a broken import in a README code example and un-rebranded content in CONTRIBUTING.md — both squarely within this PR's stated scope.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

• src/splunk_ao/config.py:47-47: The new SPLUNK_AO_API_URL -> GALILEO_API_URL bridge entry (and the other bridge mappings) has no unit test covering that the value is propagated into the environment. Consider adding a test for _bridge_env_vars() that asserts SPLUNK_AO_* values are copied to GALILEO_* keys and that existing GALILEO_* values are not overwritten.
• .github/workflows/ci-tests-splunk-ao-adk.yaml:24-24: pyproject.toml declares requires-python = ">=3.10,<3.15", but the CI matrix tests 3.11–3.14 and omits 3.10. Consider adding "3.10" to the matrix so the lowest supported version is exercised.

[fercor-cisco]

🟡 minor (bug): Broken import in the ingestion-hook example. The splunk_ao package no longer exports GalileoLogger — it exports SplunkAOLogger (see src/splunk_ao/__init__.py and src/splunk_ao/logger/__init__.py, whose __all__ is ["SplunkAOLogger"]). A user copy-pasting this snippet will hit ImportError. The rename that this PR performed for the ADK classes was missed here. Update both the import and the constructor call.

Suggested change

	from splunk_ao import GalileoLogger
	from galileo_adk import GalileoADKPlugin
	from splunk_ao_adk import SplunkAOADKPlugin
	from google.adk.runners import Runner
	from google.adk.agents import LlmAgent
	from google.genai import types
	logger = GalileoLogger(
	from splunk_ao import SplunkAOLogger
	from splunk_ao_adk import SplunkAOADKPlugin
	from google.adk.runners import Runner
	from google.adk.agents import LlmAgent
	from google.genai import types
	logger = SplunkAOLogger(

[fercor-cisco]

This is probably because of another renaming that landed recently, but it looks like it would be good to fix before merging.

[fercor-cisco]

🟡 minor (documentation): This file was only partially rebranded — the diff changed just two lines (src/galileo_adk/ path and the --cov flag). The rest still reads as the old package: the heading # Contributing to galileo-adk, links to rungalileo/galileo-python, the architecture diagram class names (GalileoADKPlugin, GalileoADKCallback, GalileoObserver, GalileoLogger, GalileoBaseHandler), cd galileo-adk, the galileo>=1.45.0 dependency example, the Release galileo-adk workflow reference, and docs.rungalileo.io. Since rebranding the docs is an explicit goal of this PR, this file should be updated for consistency with README.md and the renamed source.

[fercor-cisco]

Change what is reasonable, but it is OK to leave some of this documentation to be updated at a later time.

[adityamehra]

Addressing new review comments from @fercor-cisco (commit 15dc3cf):

README.md — broken GalileoLogger import (line 195)
Fixed: updated the ingestion-hook example to use SplunkAOLogger for both the import and the constructor call.

CONTRIBUTING.md — partial rebrand
Fully rebranded:

• Heading/intro: galileo-adk → splunk-ao-adk
• Monorepo link: rungalileo/galileo-python → splunk/splunk-ao-python
• Directory tree entries updated
• Architecture diagram: all class names updated (GalileoADKPlugin → SplunkAOADKPlugin, GalileoADKCallback → SplunkAOADKCallback, GalileoObserver → SplunkAOObserver, GalileoLogger → SplunkAOLogger, GalileoBaseHandler → SplunkAOBaseHandler, Galileo Backend → Splunk AO Backend)
• TraceBuilder section, setup commands, release sequence, workflow name, and issue/docs links all updated

[adityamehra]

Added tests/test_config.py unit tests for _bridge_env_vars() in commit 28f65b2:

1. Propagation (test_bridge_env_vars_propagates_splunk_ao_to_galileo) — parametrized over all 13 bridge pairs; asserts each SPLUNK_AO_* value is copied to its GALILEO_* counterpart when that counterpart is absent.
2. Non-overwrite (test_bridge_env_vars_does_not_overwrite_existing_galileo_value) — parametrized over all 13 pairs; asserts an explicit GALILEO_* already in the environment is never clobbered.
3. Absence (test_bridge_env_vars_skips_absent_splunk_ao_keys) — asserts no spurious GALILEO_* entries are introduced when all SPLUNK_AO_* sources are absent.
4. SPLUNK_AO_API_URL regression (test_bridge_env_vars_api_url_specifically) — dedicated test for the self-hosted deployment bridge entry.

[adityamehra]

Follow-up fix in commit 84e59ad:

SPLUNK_AO_API_URL bridge removed — api_url is an internal galileo-core field derived automatically from console_url (it just swaps console → api in the hostname). There is no user-facing GALILEO_API_URL env var in the upstream rungalileo/galileo-python SDK, and it is absent from our own _CONFIGURATION_KEYS. The bridge entry SPLUNK_AO_API_URL → GALILEO_API_URL was introduced by mistake during rebranding. Self-hosted users should set SPLUNK_AO_CONSOLE_URL (which is correctly bridged and from which api_url is derived).

Test isolation fixed — replaced monkeypatch with patch.dict(os.environ) in all test_bridge_env_vars_* tests. _bridge_env_vars() writes directly to os.environ, bypassing monkeypatch tracking; this caused GALILEO_API_URL = "test-value-for-SPLUNK_AO_API_URL" (an invalid URL) to leak into subsequent tests and break Pydantic validation in their autouse fixture setup. patch.dict snapshots and fully restores os.environ on block exit, eliminating the leakage. Also removed the SPLUNK_AO_API_URL parametrization case and use valid URL strings for URL-type keys.

[fercor-cisco]

🤖 This review was generated by the Astra agent. It may contain mistakes.

Verdict: approve — Rebrand renames are consistent and correct; handler param renames match the library. Prior major issues are resolved. Only minor doc leftovers remain.

General Comments

• 🔵 nit (documentation): The PR's stated goal is a full rebrand, but several source docstrings and a test class still say "Galileo": data_converters.py (lines 1, 22, 45, 157), types.py (line 1), span_manager.py (lines 1, 19), plugin.py (line 233), observer.py (lines 258, 260), trace_builder.py (lines 4, 50), and tests/test_retriever.py (class TestGalileoRetrieverDecorator). These are non-functional, but worth a sweep for consistency since rebranding is the explicit intent. A prior reviewer already noted it is acceptable to defer some doc cleanup, so this is non-blocking.

[fercor-cisco]

🟡 minor (documentation): The link text was rebranded to "Splunk AO Documentation" but the URL still points to Galileo's docs domain (docs.rungalileo.io). This sends users to the wrong (third-party) site. Update to the correct Splunk AO docs URL, or drop the link until one exists.

Suggested change

	- [Splunk AO Documentation](https://docs.rungalileo.io/)
	- [Splunk AO Documentation](https://docs.splunk.com/)

[fercor-cisco]

As discussed, we can defer this change.