rename(api-key): Rename galileo_api_key to splunk_ao_api_key by adityamehra · Pull Request #64 · splunk/splunk-ao-python

adityamehra · 2026-07-02T22:04:16Z

Rename galileo_api_key to splunk_ao_api_key

fercor-cisco

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Complete, consistent attribute rename with no remaining references and tests updated in lockstep.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

src/splunk_ao/configuration.py:291-291: The docstring for the renamed attribute still reads 'API key for Galileo authentication (sensitive)'. Since the attribute is now splunk_ao_api_key, consider updating this and the surrounding 'Galileo console'/'Galileo authentication' wording to Splunk AO branding for consistency (out of scope for this narrow rename).

fercor-cisco

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: request_changes — A blind find/replace corrupted test URL literals into invalid strings containing a space ("Splunk AO.ai"), outside the PR's rename scope.

General Comments

🟠 major (bug): The source rename (galileo_api_key -> splunk_ao_api_key) is correct and complete (no stray references remain). However, the test file changes go beyond the stated scope: a global find/replace of "galileo" -> "Splunk AO" also rewrote URL string literals, producing invalid URLs that contain a space, e.g. https://app.Splunk AO.ai. These are nonsensical fixture values. That the untouched DEFAULT_CONSOLE_URL and the assertion at test_configuration.py:306 still use https://app.galileo.ai/ confirms the intended host was galileo.ai. Please restore the URL literals (revert the galileo.ai -> Splunk AO.ai portion) so the rename is limited to the API-key attribute.

Follow-ups

Suggested follow-up work that could be tracked as Shortcut stories:

src/splunk_ao/constants/__init__.py:8-8: DEFAULT_CONSOLE_URL still points at https://app.galileo.ai/. If the product is being rebranded from Galileo to Splunk AO, the default console URL likely needs updating too — but that is a separate change from this API-key rename and should be tracked/decided independently.

fercor-cisco · 2026-07-02T23:57:32Z

-            ("galileo_api_key", "env-key", "internal-key"),
-            ("console_url", "https://env.galileo.ai", "https://internal.galileo.ai"),
+            ("splunk_ao_api_key", "env-key", "internal-key"),
+            ("console_url", "https://env.Splunk AO.ai", "https://internal.Splunk AO.ai"),


🟠 major (bug): These URLs were mangled by the find/replace — galileo.ai became Splunk AO.ai (note the space), which is not a valid URL. Restore the original host.

Suggested change

("console_url", "https://env.Splunk AO.ai", "https://internal.Splunk AO.ai"),

("console_url", "https://env.galileo.ai", "https://internal.galileo.ai"),

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:33Z

        mock_env_file.write_text(
            'SPLUNK_AO_API_KEY="env-file-key"\n'
-            'SPLUNK_AO_CONSOLE_URL="https://envfile.galileo.ai"\n'
+            'SPLUNK_AO_CONSOLE_URL="https://envfile.Splunk AO.ai"\n'


🟠 major (bug): Invalid URL introduced by the find/replace (contains a space). Restore galileo.ai.

Suggested change

'SPLUNK_AO_CONSOLE_URL="https://envfile.Splunk AO.ai"\n'

'SPLUNK_AO_CONSOLE_URL="https://envfile.galileo.ai"\n'

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:33Z

        # Verify env file was loaded
        assert api_key == "env-file-key"
-        assert Configuration.console_url == "https://envfile.galileo.ai"
+        assert Configuration.console_url == "https://envfile.Splunk AO.ai"


🟠 major (bug): This assertion now compares against the mangled URL. Restore galileo.ai to match the fixture at line 175.

Suggested change

assert Configuration.console_url == "https://envfile.Splunk AO.ai"

assert Configuration.console_url == "https://envfile.galileo.ai"

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:34Z

        # Set valid configuration
        monkeypatch.setenv("SPLUNK_AO_API_KEY", "valid-key")
-        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")
+        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")


🟠 major (bug): Invalid URL (contains a space) from the find/replace. Restore galileo.ai.

Suggested change

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:35Z


        # Set only console URL
-        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")
+        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")


🟠 major (bug): Invalid URL (contains a space) from the find/replace. Restore galileo.ai.

Suggested change

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:35Z

        # Set valid configuration
        monkeypatch.setenv("SPLUNK_AO_API_KEY", "valid-key")
-        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")
+        monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")


🟠 major (bug): Invalid URL (contains a space) from the find/replace. Restore galileo.ai.

Suggested change

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")

monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")

🤖 Generated by the Astra agent

fercor-cisco · 2026-07-02T23:57:36Z

-        Configuration.galileo_api_key = "test-key"
-        Configuration.console_url = "https://test.galileo.ai"
+        Configuration.splunk_ao_api_key = "test-key"
+        Configuration.console_url = "https://test.Splunk AO.ai"


🟠 major (bug): Invalid URL (contains a space) from the find/replace. Restore galileo.ai.

Suggested change

Configuration.console_url = "https://test.Splunk AO.ai"

Configuration.console_url = "https://test.galileo.ai"

🤖 Generated by the Astra agent

fercor-cisco

🤖 This review was generated by the Astra agent (claude-opus-4-8). It may contain mistakes.

Verdict: approve — Clean, consistent rename of galileo_api_key → splunk_ao_api_key; the mangled-URL bugs raised in review are already fixed on the current head.

rename(api-key): Rename galileo_api_key to splunk_ao_api_key

434ad36

fercor-cisco reviewed Jul 2, 2026

View reviewed changes

fercor-cisco previously approved these changes Jul 2, 2026

View reviewed changes

rename: Galileo to Splunk AO

21585fb

adityamehra dismissed fercor-cisco’s stale review via 21585fb July 2, 2026 23:18

fercor-cisco reviewed Jul 2, 2026

View reviewed changes

fix url

54b20eb

fercor-cisco reviewed Jul 7, 2026

View reviewed changes

fercor-cisco approved these changes Jul 7, 2026

View reviewed changes

adityamehra merged commit 4221cb9 into main Jul 7, 2026
13 checks passed

adityamehra deleted the feat/rename-galileo-api-key branch July 7, 2026 04:48

github-actions Bot locked and limited conversation to collaborators Jul 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

rename(api-key): Rename galileo_api_key to splunk_ao_api_key#64

rename(api-key): Rename galileo_api_key to splunk_ao_api_key#64
adityamehra merged 3 commits into
mainfrom
feat/rename-galileo-api-key

adityamehra commented Jul 2, 2026 •

edited

Loading

Uh oh!

fercor-cisco left a comment

Uh oh!

fercor-cisco left a comment

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco Jul 2, 2026

Uh oh!

fercor-cisco left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	("console_url", "https://env.Splunk AO.ai", "https://internal.Splunk AO.ai"),
	("console_url", "https://env.galileo.ai", "https://internal.galileo.ai"),

	'SPLUNK_AO_CONSOLE_URL="https://envfile.Splunk AO.ai"\n'
	'SPLUNK_AO_CONSOLE_URL="https://envfile.galileo.ai"\n'

	assert Configuration.console_url == "https://envfile.Splunk AO.ai"
	assert Configuration.console_url == "https://envfile.galileo.ai"

	monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.Splunk AO.ai")
	monkeypatch.setenv("SPLUNK_AO_CONSOLE_URL", "https://app.galileo.ai")

	Configuration.console_url = "https://test.Splunk AO.ai"
	Configuration.console_url = "https://test.galileo.ai"

Uh oh!

Conversation

adityamehra commented Jul 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fercor-cisco left a comment

Choose a reason for hiding this comment

Follow-ups

Uh oh!

fercor-cisco left a comment

Choose a reason for hiding this comment

General Comments

Follow-ups

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco Jul 2, 2026

Choose a reason for hiding this comment

Uh oh!

fercor-cisco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adityamehra commented Jul 2, 2026 •

edited

Loading