Skip to content

Conversation

@leonard84
Copy link
Member

@leonard84 leonard84 commented Apr 3, 2019

This change is Reviewable

@leonard84 leonard84 requested a review from marcphilipp April 3, 2019 19:55
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #984 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #984   +/-   ##
=========================================
  Coverage     75.99%   75.99%           
  Complexity     3544     3544           
=========================================
  Files           377      377           
  Lines         10788    10788           
  Branches       1374     1374           
=========================================
  Hits           8198     8198           
  Misses         2109     2109           
  Partials        481      481

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d751a0a...90c2557. Read the comment docs.

Copy link
Member

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have those keys added in a commit signed itself with the key which is somehow (https://keybase.io/ ? personal meeting at some conference?) associated with you @leonard84 .

Copy link
Member

@szpak szpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most of the cases it's better to have it documented in that form than not at all. I created #989 to verify them somehow. Please merge as you wish.

@szpak szpak added this to the 2.0 milestone Feb 4, 2020
@leonard84 leonard84 removed this from the 2.0 milestone Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants