Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: genius scrapper lyrics container div #2304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: genius scrapper lyrics container div #2304

wants to merge 1 commit into from
+3 −0

Conversation

Lucas-Monsegu
Copy link

Title

Fix genius scrapper

Description

The genius website seem to have changed breaking the download lyrics feature. It looks like the HTML structure of the Genius lyrics page has changed. The new lyrics container is now wrapped in a div with data-lyrics-container="true".

Related Issue

#2302

Motivation and Context

It fix the genius scrapping for lyrics

How Has This Been Tested?

Locally with simple tests

Screenshots (if appropriate)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the CONTRIBUTING document
  • I have read the CORE VALUES document
  • I have added tests to cover my changes
  • All new and existing tests passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Lucas-Monsegu