Skip to content

Validate input args in luigi.run()#3413

Open
subhramit wants to merge 5 commits intospotify:masterfrom
subhramit:fix-typerror-run
Open

Validate input args in luigi.run()#3413
subhramit wants to merge 5 commits intospotify:masterfrom
subhramit:fix-typerror-run

Conversation

@subhramit
Copy link
Copy Markdown

Description

Validate passed args in run() before passing anything downstream.

Motivation and Context

Closes #3354

Quoting from the linked issue:

luigi.run() should validate that the input args is an iterable and raise a meaningful TypeError or ValueError such as:TypeError: luigi.run() expects a list or tuple of command-line arguments, got int.

This adds the above validation.

Have you tested this? If so, how?

I added unit tests and ran them.

@subhramit subhramit requested review from a team and dlstadther as code owners April 8, 2026 02:30
Signed-off-by: subhramit <subhramit.bb@live.in>
@subhramit
Copy link
Copy Markdown
Author

subhramit commented Apr 8, 2026

Hi, I'm not sure what other tests to add to satisfy codecov.

Edit - after a while, it passed on its own somehow.

@subhramit subhramit changed the title Validate input args in luigi.run() Validate input args in luigi.run() Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeError in luigi.run()

1 participant