SOCIALFB-34 Assign proper values to ad creative type

spring-social-facebook/src/main/java/org/springframework/social/facebook/api/ads/AdCreative.java

@@ -27,7 +27,26 @@
  */
 public class AdCreative {
 	public enum AdCreativeType {
-		NONE, DEFAULT_BASIC_LINK_AD, INLINE_LIKE, EVENT_RSVP, APP_AD, SPONSORED_STORY_FOR_AN_APP_SHARE, SPONSORED_STORY_FOR_A_PAGE_LIKE_EVENT, SPONSORED_STORY_FOR_A_PLACE_CHECKIN_EVENT, SPONSORED_STORY_FOR_AN_APP_USED, SPONSORED_STORY_FOR_A_PAGE_POST_LIKE, SPONSORED_STORY_FOR_A_DOMAIN, SPONSORED_STORY_FOR_A_FACEBOOK_PAGE_UPDATE
+		DEFAULT_BASIC_LINK_AD(1), INLINE_LIKE(2), EVENT_RSVP(3), APP_AD(4), SPONSORED_STORY_FOR_AN_APP_SHARE(
+				8), SPONSORED_STORY_FOR_A_PAGE_LIKE_EVENT(9), SPONSORED_STORY_FOR_A_PLACE_CHECKIN_EVENT(
+				10), SPONSORED_STORY_FOR_AN_APP_USED(16), SPONSORED_STORY_FOR_A_PAGE_POST_LIKE(
+				17), SPONSORED_STORY_FOR_A_DOMAIN(19), SPONSORED_STORY_FOR_A_FACEBOOK_PAGE_UPDATE(
+				27);
+
+		private int value;
+
+		private AdCreativeType(int value) {
+			this.value = value;
+		}
+
+		public static AdCreativeType findByValue(int value) {
+			for (AdCreativeType type : values()) {
+				if (type.value == value) {
+					return type;
+				}
+			}
+			return null;
+		}
 	}
 
 	private String name;

spring-social-facebook/src/main/java/org/springframework/social/facebook/api/ads/impl/json/AdCreativeMixin.java

@@ -18,7 +18,9 @@
 import org.codehaus.jackson.annotate.JsonCreator;
 import org.codehaus.jackson.annotate.JsonIgnoreProperties;
 import org.codehaus.jackson.annotate.JsonProperty;
+import org.codehaus.jackson.map.annotate.JsonDeserialize;
 import org.springframework.social.facebook.api.ads.AdCreative;
+import org.springframework.social.facebook.api.ads.AdCreative.AdCreativeType;
 
 /**
  * A Jackson mixin for the {@link AdCreative} object.
@@ -31,6 +33,10 @@ abstract class AdCreativeMixin {
 	AdCreativeMixin() {
 	}
 
+	@JsonProperty("type")
+	@JsonDeserialize(using=AdCreativeTypeDeserializer.class)
+	AdCreativeType type;
+
 	@JsonProperty("object_id")
 	int objectId;
 

spring-social-facebook/src/main/java/org/springframework/social/facebook/api/ads/impl/json/AdCreativeTypeDeserializer.java

@@ -0,0 +1,38 @@
+/*
+ * Copyright 2010 the original author or authors.
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.springframework.social.facebook.api.ads.impl.json;
+
+import java.io.IOException;
+
+import org.codehaus.jackson.JsonParser;
+import org.codehaus.jackson.JsonProcessingException;
+import org.codehaus.jackson.map.DeserializationContext;
+import org.codehaus.jackson.map.JsonDeserializer;
+import org.springframework.social.facebook.api.ads.AdCreative.AdCreativeType;
+
+/**
+ * A deserializer for parsing a {@link AdCreativeType} enum value.
+ * 
+ * @author Karthick Sankarachary
+ */
+public class AdCreativeTypeDeserializer extends JsonDeserializer<AdCreativeType> {
+	@Override
+	public AdCreativeType deserialize(JsonParser jp, DeserializationContext ctxt)
+			throws IOException, JsonProcessingException {
+		return AdCreativeType.findByValue(Integer.valueOf(jp.getText()
+				.toUpperCase()));
+	}
+}