Enhance MVC CircuitBreaker: add support for 'not permitted' handling and resume-without-error behavior #4000
+332
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raccoonback
force-pushed
the
mvc-circuitbreaker-enhancements
branch
from
c64e737 to
8c6e4da
Compare
Contributor
Author
|
@ryanjbaxter @spencergibb |
…ror cases - Return 503 Service Unavailable when CircuitBreaker is open or not permitted - Return 200 OK when resume-without-error is configured Signed-off-by: raccoonback <[email protected]>
raccoonback
force-pushed
the
mvc-circuitbreaker-enhancements
branch
from
8c6e4da to
8254758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The existing MVC implementation did not handle
CallNotPermittedExceptionand lacked a way to "resume without error," which is frequently needed in real-world production systems where graceful degradation is desired.Summary
This PR enhances the MVC
CircuitBreakerFilterFunctionsby adding missing error-handling cases and introducing a new configuration option (resumeWithoutError).The goal is to align the MVC implementation more closely with the WebFlux CircuitBreaker behavior and improve overall resilience and configurability.
Key Changes
CallNotPermittedExceptionCallNotPermittedException), the filter now returns:503 Service Unavailable
resumeWithoutErroroptionresumeWithoutError