Support epoch millisecond values for datetime predicates in WebMVC #4005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable After, Before, and Between predicates to accept epoch milliseconds in YAML configuration by automatically registering StringToZonedDateTimeConverter to the ConversionService used by RouterFunctionHolderFactory Signed-off-by: raccoonback <[email protected]>
raccoonback
commented
Nov 30, 2025
Comment on lines
+147
to
+151
| if (this.conversionService instanceof ConfigurableConversionService configurableConversionService) { | ||
| configurableConversionService.addConverter(new StringToZonedDateTimeConverter()); | ||
| } | ||
|
|
||
| this.parameterValueMapper = new ConversionServiceParameterValueMapper(this.conversionService); |
Contributor
Author
There was a problem hiding this comment.
The custom StringToZonedDateTimeConverter is not registered in the shared ConversionService instance, so this PR explicitly registers it in the actual ConversionService used by WebMVC. This ensures that datetime predicates can correctly parse both ISO-8601 strings and epoch millisecond values.
Comment on lines
+31
to
+45
| public class StringToZonedDateTimeConverter implements Converter<String, ZonedDateTime> { | ||
|
|
||
| @Override | ||
| public ZonedDateTime convert(String source) { | ||
| try { | ||
| long epoch = Long.parseLong(source); | ||
| return Instant.ofEpochMilli(epoch).atOffset(ZoneOffset.ofTotalSeconds(0)).toZonedDateTime(); | ||
| } | ||
| catch (NumberFormatException e) { | ||
| // try ZonedDateTime instead | ||
| return ZonedDateTime.parse(source); | ||
| } | ||
| } | ||
|
|
||
| } |
Contributor
Author
Contributor
Author
|
@ryanjbaxter @spencergibb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
WebMVC predicates previously accepted only ISO-8601 timestamps, limiting usability for configurations that rely on epoch values (common in distributed systems and machine-generated configs).
This PR enhances the developer experience and aligns WebMVC predicate behavior with the more flexible usage found in other parts of Spring.
Summary
This PR adds support for using epoch millisecond values in WebMVC datetime predicates (
After,Before,Between) when configured through YAML.Introduces
StringToZonedDateTimeConverterto convert both:ZonedDateTimeRegisters the converter in
RouterFunctionHolderFactorywhen the underlyingConversionServiceis configurable.Updates
ConversionServiceParameterValueMapperto rely on the injectedConversionService.Provides full integration test coverage:
Adds sample
application-datetime.ymlused by integration tests.