Fix race condition in StepContribution.filterCount #5189
+161
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
What about other counts? |
KMGeon
force-pushed
the
GH-5188
branch
2 times, most recently
from
358b8d8 to
ab01952
Compare
Contributor
Author
Thank you for your feedback! I've added Regarding other count fields ( Let me know if you think those should be converted as well for consistency. |
Signed-off-by: mugeon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change filterCount field from long to AtomicLong to ensure thread-safety when incrementing filter count in concurrent chunk processing.
Resolves #5188