Skip to content

GraphQlWebMvcAutoConfiguration should apply customizers in order#50908

Merged
snicoll merged 2 commits into
spring-projects:4.0.xfrom
quaff:patch-224
Jul 3, 2026
Merged

GraphQlWebMvcAutoConfiguration should apply customizers in order#50908
snicoll merged 2 commits into
spring-projects:4.0.xfrom
quaff:patch-224

Conversation

@quaff

@quaff quaff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 3, 2026
@snicoll

snicoll commented Jul 3, 2026

Copy link
Copy Markdown
Member

@quaff thanks, but those two are very different. The change on DataSourcePoolMetadataProvider is less conflictual, I think. The one for GraphQL should be treated as a bug though. Can you please open a separate PR so that each have a single change? Thank you.

@snicoll snicoll added the status: waiting-for-feedback We need additional information before we can continue label Jul 3, 2026
@quaff quaff changed the title Use orderedStream() to respect order of beans Improve GraphQlWebMvcAutoConfiguration to respect order of customizers Jul 3, 2026
@quaff

quaff commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

@quaff thanks, but those two are very different. The change on DataSourcePoolMetadataProvider is less conflictual, I think. The one for GraphQL should be treated as a bug though. Can you please open a separate PR so that each have a single change? Thank you.

@snicoll Updated this PR and created #50911.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jul 3, 2026
@snicoll snicoll changed the title Improve GraphQlWebMvcAutoConfiguration to respect order of customizers GraphQlWebMvcAutoConfiguration should apply customizers in order Jul 3, 2026
@snicoll snicoll added type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Jul 3, 2026
@snicoll snicoll added this to the 4.0.8 milestone Jul 3, 2026
@snicoll snicoll changed the base branch from main to 4.0.x July 3, 2026 10:32
@snicoll snicoll self-assigned this Jul 3, 2026
@snicoll snicoll merged commit d2b538b into spring-projects:4.0.x Jul 3, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A general bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants