Use virtual threads for auto-configured RedisMessageListenerContainer#50917
Closed
SebTardif wants to merge 1 commit into
Closed
Use virtual threads for auto-configured RedisMessageListenerContainer#50917SebTardif wants to merge 1 commit into
SebTardif wants to merge 1 commit into
Conversation
When spring.threads.virtual.enabled is true, configure the Redis message listener container with a virtual-thread SimpleAsyncTaskExecutor, matching Kafka and Rabbit listener auto-configuration. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
spring-projects-issues
added
the
status: waiting-for-triage
Member
|
#50884 is already assigned to someone and therefore is not open for contributions. Thanks anyway for the PR. |
wilkinsona
added
status: declined
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Auto-configured
RedisMessageListenerContainerignoredspring.threads.virtual.enabled. Kafka and Rabbit listener auto-configuration already use virtual-thread executors when that property is true.Change
TaskExecutorsupport onRedisMessageListenerContainerConfigurer.@ConditionalOnThreading(Threading.VIRTUAL)configurer bean that sets a virtual-threadSimpleAsyncTaskExecutor(same pattern as Kafka listeners).Testing
Manual review against Kafka/Rabbit virtual-thread patterns. Format with project formatter in CI.
AI assistance
This change was developed with AI coding assistance. I reviewed the code.
Related to #50884