Skip to content

Fix broken docs caused by incorrect feature-scroll usage in Antora #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix broken docs caused by incorrect feature-scroll usage in Antora #3262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/main/antora/modules/ROOT/pages/index.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
Oliver Gierke; Thomas Darimont; Christoph Strobl; Mark Pollack; Thomas Risberg; Mark Paluch; Jay Bryant
:revnumber: {version}
:revdate: {localdate}
:feature-scroll: true

(C) 2008-2025 The original authors.

Expand Down
1 change: 1 addition & 0 deletions src/main/antora/modules/ROOT/pages/repositories/core-concepts.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[[repositories.core-concepts]]
= Core concepts
:feature-scroll:

The central interface in the Spring Data repository abstraction is `Repository`.
It takes the domain class to manage as well as the identifier type of the domain class as type arguments.
Expand Down
5 changes: 2 additions & 3 deletions src/main/antora/modules/ROOT/pages/repositories/query-methods-details.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
[[repositories.query-methods.details]]
= Defining Query Methods
:feature-scroll:

The repository proxy has two ways to derive a store-specific query from the method name:

Expand Down Expand Up @@ -457,10 +458,10 @@ ifdef::feature-scroll[]
| `limit + 1` at `OffsetScrollPosition.getOffset()`
| One to many queries fetching data starting at `OffsetScrollPosition.getOffset()` applying limiting.
a| A `Window` can only navigate to the next `Window`.
endif::[]

* `Window` provides details whether there is more data to fetch.
* Offset-based queries becomes inefficient when the offset is too large because the database still has to materialize the full result.
endif::[]

| `Page<T>`
| `Pageable.getPageSize()` at `Pageable.getOffset()`
Expand Down Expand Up @@ -518,8 +519,6 @@ QSort sort = QSort.by(QPerson.firstname.asc())
.and(QSort.by(QPerson.lastname.desc()));
----

ifdef::feature-scroll[]
endif::[]

[[repositories.limit-query-result]]
=== Limiting Query Results
Expand Down