Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JoinType on associations when using MatchMode.ANY #3794

Closed
wants to merge 1 commit into from
Closed

Fix JoinType on associations when using MatchMode.ANY #3794

wants to merge 1 commit into from

Conversation

ArnaudLec
Copy link
Contributor

@ArnaudLec ArnaudLec commented Feb 28, 2025 •
edited
Loading

Fixes #3763

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@ArnaudLec ArnaudLec force-pushed the bugfix/datajpa-3763 branch 3 times, most recently from 78abfcd to a9f31e5 Compare February 28, 2025 17:24
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 28, 2025
@ArnaudLec ArnaudLec force-pushed the bugfix/datajpa-3763 branch 2 times, most recently from c628903 to 623a4a9 Compare February 28, 2025 17:32
christophstrobl pushed a commit that referenced this pull request Mar 6, 2025
@ArnaudLec @christophstrobl
Consider MatchMode when joining associations for QueryByExample.
44c88db 
This commit makes sure to use different join types depending on the actual match mode.

Closes: #3763
Original Pull Request: #3794

Signed-off-by: ArnaudLec <[email protected]>
christophstrobl added a commit that referenced this pull request Mar 6, 2025
@christophstrobl
Add integration test for QueryByExample match mode on associations.
f04762a 
Original Pull Request: #3794
christophstrobl pushed a commit that referenced this pull request Mar 6, 2025
@ArnaudLec @christophstrobl
Consider MatchMode when joining associations for QueryByExample.
99840c9 
This commit makes sure to use different join types depending on the actual match mode.

Closes: #3763
Original Pull Request: #3794

Signed-off-by: ArnaudLec <[email protected]>
christophstrobl added a commit that referenced this pull request Mar 6, 2025
@christophstrobl
Add integration test for QueryByExample match mode on associations.
85429ff 
Original Pull Request: #3794
@christophstrobl christophstrobl added this to the 3.4.4 (2024.1.4) milestone Mar 6, 2025
@christophstrobl
Copy link
Member

Thank you @ArnaudLec! Merged to main and 3.4.x development lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christophstrobl christophstrobl

Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Milestone
3.4.4 (2024.1.4)
Development

Successfully merging this pull request may close these issues.

Invalid JoinType in QueryByExamplePredicateBuilder when using MatchMode ANY
3 participants
@ArnaudLec @christophstrobl @spring-projects-issues