Add /api/version endpoint to show app version #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR. What's the reason for exposing the version? |
| public class VersionController { | ||
|
|
||
| @Value("${app.version:unknown}") | ||
| private String version ="unknown"; |
Contributor
There was a problem hiding this comment.
Suggested change
| private String version ="unknown"; | |
| private String version = "unknown"; |
| public class VersionController { | ||
|
|
||
| @Value("${app.version:unknown}") | ||
| private String version ="unknown"; |
Contributor
There was a problem hiding this comment.
Why it's default here, you have default on annotation level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added a new REST endpoint
/api/versionthat returns the current application version defined inpom.xml.Implementation Details
VersionControllerinorg.springframework.samples.petclinic.system.app.versionproperty toapplication.properties.pom.xmlto enable Maven resource filtering.Verification
mvn clean package.http://localhost:8080/api/versionreturns:{
"version": "4.0.0-SNAPSHOT"
}