Provided uncached way to use (Reactive)OidcIdTokenDecoderFactory #16647
Conversation
Signed-off-by: iigolovko <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
|
Hey @iigolovko thanks for your valuable suggestion, but it would be better to create a ticket for this feature. It is quite possible that as a result of discussion we will find another solution if necessary. |
|
fixes #16655 |
Looks like #16655 affects a lot. Any chance that can be reviewed and handled somehow? @franticticktick |
| @@ -78,7 +79,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory<Client | |||
|
|
|||
| private static final ClaimTypeConverter DEFAULT_CLAIM_TYPE_CONVERTER = createDefaultClaimTypeConverter(); | |||
|
|
|||
| private final Map<String, JwtDecoder> jwtDecoders = new ConcurrentHashMap<>(); | |||
| private final Map<String, JwtDecoder> jwtDecoders; | |||
There was a problem hiding this comment.
My 2 cents.
I think that caching in general is a functionality that needs to be extracted from here. Maybe the core maintainers can consider introducing the CachingOidcIdTokenDecoderFactory that extend OidcIdTokenDecoderFactory and adds caching functionality. Or the alternative solution via decorator/caching delegate is better.
Hello.
Sorry for ignoring issue creating.
If ClientRegistration is managed by db, it's unreal to update jwsAlgorithm or jwksUri without restarting the app.
So I added possibility not to use ConcurrentHashMap on decoder creation to build new one everytime. It will be useful in some multi-integration cases.