Fix HttpSessionRequestCache#getMatchingRequest query string parsing
#16914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- URL parsing changed in framework 6.2, and fails when path contains a % sign. - The HttpSessionRequestCache only needs to inspect the query string, not the full URL. Fixes spring-projectsgh-16656 Signed-off-by: Daniel Garnier-Moiroux <[email protected]>
Kehrlann
changed the title
HttpSessionRequestCache#getMatchingRequest query string parsing
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
URL parsing changed in framework 6.2 (security 6.4), and now fails when path contains a
%sign. As a result, theHttpSessionRequestCachefails on every request where the path contains a%sign.Resolution
We do not need to parse a full URL, just to inspect the query string for the matching parameter. We don't use the current request path in
UriComponentsBuilderto extract the query string.Fixes gh-16656