Make AuthorizationProxyFactory.proxy generic #16996
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dae won <[email protected]>
…ignature Signed-off-by: dae won <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
jzheaux
requested changes
May 1, 2025
| @@ -335,7 +335,7 @@ public void setTargetVisitorThenUses() { | |||
| @Test | |||
| public void setTargetVisitorIgnoreValueTypesThenIgnores() { | |||
| AuthorizationAdvisorProxyFactory factory = AuthorizationAdvisorProxyFactory.withDefaults(); | |||
| assertThatExceptionOfType(ClassCastException.class).isThrownBy(() -> ((Integer) factory.proxy(35)).intValue()); | |||
| assertThatExceptionOfType(ClassCastException.class).isThrownBy(() -> (factory.proxy(35)).intValue()); | |||
There was a problem hiding this comment.
It looks like the parentheses are no longer needed around factory.proxy(35). Can you remove them please?
| @@ -20,6 +20,7 @@ | |||
| * A factory for wrapping arbitrary objects in authorization-related advice | |||
| * | |||
| * @author Josh Cummings | |||
| * @author daewon kim | |||
There was a problem hiding this comment.
Will you please update the copyright year in this file and any other file you modify to 2025?
jzheaux
added
in: core
Signed-off-by: dae won <[email protected]>
big-cir
force-pushed
the
refactor/generic-proxy-method
branch
from
70bab2b to
7b8ba13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request updates the AuthorizationProxyFactory interface to make its proxy method generic, ensuring that it returns the same type as the input object.
The following changes are included:
Related
ISSUE: #16706
Note
I’m aware that the issue is currently labeled with status: waiting-for-triage, which indicates that the final design direction may not be settled yet. This PR reflects my current understanding of the issue and is intended as a starting point for further discussion.
If this approach does not align with the intended direction, please feel free to close the PR or provide feedback. I am happy to revise or take a different direction as needed. Thank you!