Use idiomatic Kotlin in custom filter documentation#18976
Merged
jzheaux merged 3 commits intospring-projects:mainfrom Mar 27, 2026
Merged
Use idiomatic Kotlin in custom filter documentation#18976jzheaux merged 3 commits intospring-projects:mainfrom
jzheaux merged 3 commits intospring-projects:mainfrom
Conversation
therepanic
commented
Mar 24, 2026
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
Author
|
Tests failing due to 2a8976f |
This will make Kotlin and all users more native and readable. Closes: spring-projectsgh-18967 Signed-off-by: Andrey Litvitski <andrey1010102008@gmail.com>
jzheaux
added
in: docs
Contributor
|
Great, @therepanic! This will merge into |
jzheaux
requested changes
Mar 27, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks for the updates, @therepanic. I've left some feedback inline.
...c/test/java/org/springframework/security/docs/servlet/addingcustomfilter/SecurityConfig.java
Outdated
Show resolved
Hide resolved
auto-merge was automatically disabled
March 27, 2026 20:32
Head branch was pushed to by a user without write access
therepanic
commented
Mar 27, 2026
...va/org/springframework/security/docs/servlet/addingcustomfilter/CustomFilterBeforeTests.java
Show resolved
Hide resolved
jzheaux
requested changes
Mar 27, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Thanks, @therepanic. Just one more thing, then, will you please add tests, similar to CustomFilterTests to confirm that the snippets that use addFilterAfter are working?
therepanic
commented
Mar 27, 2026
...in/org/springframework/security/kt/docs/servlet/addingcustomfilter/CustomFilterAfterTests.kt
Show resolved
Hide resolved
jzheaux
approved these changes
Mar 27, 2026
Contributor
|
Great! This is now merged into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will make Kotlin and all users more native and readable.
Closes: gh-18967